Houston4444 / RaySession

Session manager for linux musical programs
GNU General Public License v2.0
156 stars 18 forks source link

Comments in patch.xml and the jack connections are no longer made #57

Open newlaurent62 opened 4 years ago

newlaurent62 commented 4 years ago

It seems that when putting comments in the patch.xml file the jack connections are no longer done.

<RAY-JACKPATCH>
 <connection to="PulseAudio JACK Source:front-left" from="system:capture_1"/>
 <connection to="PulseAudio JACK Source:front-right" from="system:capture_2"/>
 <connection to="system:playback_1" from="PulseAudio JACK Sink:front-left"/>
 <connection to="system:playback_2" from="PulseAudio JACK Sink:front-right"/>

<!-- SNIPPET FROM Jamulus-->

 <connection to="Jamulus user1_vocal:input right" from="in_U22:capture_1"/>
 <connection to="system:playback_1" from="Jamulus user1_vocal:output left"/>
 <connection to="system:playback_2" from="Jamulus user1_vocal:output right"/>
 <connection to="Jamulus user2_guitar:input left" from="in_U22:capture_2"/>

<!--  END SNIPPET FROM Jamulus-->

<!-- SNIPPET FROM Jack_capture_for_jamulus-->

 <connection to="jack_capture:input1" from="Jamulus user2_guitar:output left"/>
 <connection to="jack_capture:input2" from="Jamulus user2_guitar:output right"/>

<!--  END SNIPPET FROM Jack_capture_for_jamulus-->

<!-- SNIPPET FROM Obs_Icecast2_audio-->

 <connection to="OBS Stream:in_1" from="Jamulus user1_vocal:output left"/>
 <connection to="OBS Stream:in_2" from="Jamulus user1_vocal:output right"/>

<!--  END SNIPPET FROM Obs_Icecast2_audio-->

<!-- SNIPPET FROM Obs_Icecast2_video-->

<!--  END SNIPPET FROM Obs_Icecast2_video-->

</RAY-JACKPATCH>
Houston4444 commented 4 years ago

I've got no idea why it doesn't works with this... ray-jackpatch uses the the Qt Xml parser.

In your process, who change this file ? The wizard before session start ? or the clients ? (I preffer largely the first choice ;) ).

Houston4444 commented 4 years ago

Ah, et n'hésite pas à me contacter sur IRC, je traîne régulièrement sur les canaux #linuxmao #librazik ou #lad .

newlaurent62 commented 4 years ago

The wizard generates this file with comments.

For testing purpose i removed manually the comments and replace the patch.xml with uncommented one.

When the patch has comments the connections are not done When the patch is not commented the connections are done

My wizard now generates a session with ray-scripts and proxies without calling the ray_control command.

That seems to work well. (i removed the XML comments but i would prefer to have them at least for debugging purpose)