search

HoverHell / RedditImageGrab

Downloads images from sub-reddits of reddit.com.
GNU General Public License v3.0
311 stars 78 forks source link

Fix deviantart #62

Closed rachmadaniHaryono closed 8 years ago

rachmadaniHaryono commented 8 years ago

to fix #56. simple implementation to parser deviant art page html. it depend on bs4 and lxml package.

jtara1 commented 8 years ago

I could probably get the same info to download a deviantart image using regex instead of bs4 & lxml if ever needed.

rachmadaniHaryono commented 8 years ago

Well, that is another option. So, should I cancel this pull request?

jtara1 commented 8 years ago

No I think it's good as is. I've tested out the similar, py3, version of this branch. It has worked well for me.

HoverHell commented 8 years ago

lxml is occasionally hard to install, and deviantart urls aren't always needed; for that reason, I'll probably leave those in extras_require.