search

HoverHell / RedditImageGrab

Downloads images from sub-reddits of reddit.com.
GNU General Public License v3.0
311 stars 78 forks source link

Made the repository python 3 compatible. #87

Open arshjat opened 5 years ago

arshjat commented 5 years ago

I've made the repository python 3 compatible after doing some major changes in the code. Major difference between what I did and the jtara1 repository is that I did only basic fixes that span up to only 3-4 line changes in reddit.py, 3-4 changes in redditdownload.py and one line change in gfycat.py and it is working perfectly.

Is there any way for my contribution to be taken?

Hoping for a response.

Revan654 commented 5 years ago

Do a Pull request, It's unlikely it will be seen since the Dev hasn't updated the code for years. It will need approval, Have no idea if he's still around or not.

It's just better to Fork the Project and just do updates from there.

rachmadaniHaryono commented 5 years ago

or better use updated fork and recruit people to collaborate

arshjat commented 5 years ago

Thank you @Revan654 and @rachmadaniHaryono for the response, I'll continue with my fork.

Revan654 commented 5 years ago

Thank you, I'll continue with my fork.

@arshjat

Not sure if you tested the Script yet, One thing I did notice is (Basing it off of Python 3.7.1):

You have: connection = urllib.urlopen

It Should be: urllib.request.urlopen

I will try it shortly. Grad someone picked it up where Orig. Dev left off.