search

Hoverbear / digitalocean

A prototype API for Digital Ocean.
https://docs.rs/crate/digitalocean/
MIT License
37 stars 11 forks source link

Add support for bucket and object creation #24

Open wafflespeanut opened 5 years ago

wafflespeanut commented 5 years ago

Addresses #23 and adds necessary stuff for Spaces API.

wafflespeanut commented 5 years ago

I'm planning to implement direct upload and multipart upload for objects, so I don't wanna land this just yet. But, it's ready for first pass! (cc @Hoverbear)

Hoverbear commented 5 years ago

Seems like the client/builder.rs would be more appropriate as request/builder.rs? (this might require a bit of a structure change for request.rs.)

wafflespeanut commented 5 years ago

Yep, the modules definitely need some structuring. request/builder.rs makes sense!

Hoverbear commented 5 years ago

Part of me wonders if some of this codebase can be reduced by using an existing AWS library for some tasks. What do you think?

wafflespeanut commented 5 years ago

Part of me wonders if some of this codebase can be reduced by using an existing AWS library for some tasks. What do you think?

rusoto is probably the only maintained AWS lib out there. Their codegen impls futures and streams for all operations. If it makes sensible to you (I don't really have an argument for/against doing this), then we'd wrap over their S3 client and expose only those features that are supported by DO.