format flag day

[posix4e]

Now that we have rust fmt in it's time to clean up all the code in raft-rs. That means breaking all of the pull requests. Let's pick a day and do it right for everyone!

[posix4e]

@Hoverbear

[Hoverbear]

@danburkert do you have any pending PRs?

@james-darkfox you have #88, I think it's no longer needed or has been covered. Can we close that?

I'm a-okay to do this any day once we know those two things.

[danburkert]

👍 from me. I'm curious what's changed in rust-fmt recently?

[posix4e]

Nothing really changed. We just decided that it was possible to rust format

[Hoverbear]

It's now more integrated and considered more de-facto!

[posix4e]

https://github.com/Hoverbear/raft-rs/pull/121

[WildCryptoFox]

@Hoverbear #88 has not been covered, and the patch reduces processing required.

https://github.com/Hoverbear/raft-rs/blob/master/src/server.rs#L355-L370

Note that in the current code the process is:

• Insert the connection into the slab
• Try to register the connection; on failure
  • Remove the connection from the slab
  • Implicit connection dropped

vs

• Reserve a slot / token for the connection
• Try to register the connection; on success
  • Insert the connection
• On failure; Implicit connection dropped

In either case. Continue with the reformat and I'll take another look into getting the Entry API into the slab in mio again.

Edit: It appears that someone has implemented the Entry API more correctly than my quick mock-up; and that has made it's way into mio's slab recently. I'll rebase against this after the reformat.

[Hoverbear]

Okay so I can accept this reformat?

[posix4e]

I talked to him it's fine On Fri, May 13, 2016 at 10:07 PM Andrew Hobden notifications@github.com wrote:

Okay so I can accept this reformat?

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/Hoverbear/raft-rs/issues/120#issuecomment-219201129

Sent from my mobile 4045076749 Alex Newman