Raft Update Post - Githubissues

Hoverbear / old-raft-rs

[Incomplete] A Raft implementation in Rust

https://hoverbear.github.io/raft-rs/raft/

MIT License

266 stars 41 forks source link

Raft Update Post #45

Closed Hoverbear closed 9 years ago

Hoverbear commented 9 years ago

I'm planning on doing a Raft update post, I'd like to talk about recent progress, changes, patterns we've found, etc.

Please feel encouraged to suggest topics and things to discuss!

[x] wrapped_enum pattern - @james-darkfox
[x] scoped_log crate - @james-darkfox / @dcb
[ ] Message handling - @hoverbear / @dcb
[ ] Elections work - @dcb
[x] @homu - @hoverbear
[x] Coveralls - @hoverbear
[ ] Meetup - @erickt
[ ] State Machine impl
[ ] Store impl
[ ] Testing
[x] Examples

Hoverbear commented 9 years ago

@james-darkfox @danburkert @huonw I posted about your new crates today: http://hoverbear.org/2015/07/16/raft-new-crates/

WildCryptoFox commented 9 years ago

wrapped_enum usage example is invalid.

pub enum -> variants aren't documented. See james-darkfox/rs-wrapped_enum-macro#1

Also worth the note that the display/debug implementations aren't internal as they are either #[derive(Debug)] or in raft's case, with a custom display to unwrap the enum. This unwrapping isn't and won't be standard for the macro due to the undesired changes for the macro and its intended usage of simply wrapping existing types.

WildCryptoFox commented 9 years ago

james-darkfox/rs-scoped_log@872ef08

Hoverbear commented 9 years ago

Updated!

Hoverbear commented 9 years ago

@erickt Do you know when the meetup will be announced?