search

Hoverbear / old-raft-rs

[Incomplete] A Raft implementation in Rust
https://hoverbear.github.io/raft-rs/raft/
MIT License
266 stars 41 forks source link

Add Hashmap StateMachine #73

Closed Hoverbear closed 9 years ago

Hoverbear commented 9 years ago

Could be preliminarily merged so it can be used for the changes we talked about with the Register StateMachine as well but still needs more work!

danburkert commented 9 years ago

Would it be possible to put this entirely in the examples/ directory? Ideally we would do that for all StateMachine implementations that aren't used in unit tests. This probably includes the register one too, I don't think we are currently using that.

Hoverbear commented 9 years ago

@danburkert I put this here on the precidence of the register example, but I do agree. I'll move the register example and do this as well.

Hoverbear commented 9 years ago

@danburkert These examples need some documentation and some cleaning but they're functional. I changed their interface a bit to make it easier to test via scripts.

I do agree that we should probably make state machine not return results and include some help on dealing with errors.

Hoverbear commented 9 years ago

Removed the Result<_,_> from StateMachine. I'd like to set up snapshotting on the examples but then should be ready for r+.

Last tests have been failing due to a dependency. We'll need to re-fire the build once it's fixed.

Hoverbear commented 9 years ago

@homu r=danburkert (Via IRC)

homu commented 9 years ago

:pushpin: Commit dc5f017 has been approved by danburkert

homu commented 9 years ago

:hourglass: Testing commit dc5f017 with merge 959bd95...

homu commented 9 years ago

:sunny: Test successful - status