search

Hoverbear / old-raft-rs

[Incomplete] A Raft implementation in Rust
https://hoverbear.github.io/raft-rs/raft/
MIT License
266 stars 41 forks source link

peers advertise their peer address #93

Closed tbg closed 8 years ago

tbg commented 8 years ago

via the preamble. For inbound connections, the preamble is the authoritative source of the peer's listening address. The information updates the Consensus instance as well as the Connection.

relates to #92, though I wouldn't quite say "fixes" yet.

I haven't had much of my Rust reviewed, so pointers appreciated.

danburkert commented 8 years ago

Looks good! Just a few small feedback comments. Thanks @tschottdorf

tbg commented 8 years ago

addressed the comments. Thanks for the quick review!

tbg commented 8 years ago

updated. I'm not sure what to do with https://github.com/Hoverbear/raft/pull/93#commitcomment-12741888, so I'm open for suggestions.

Hoverbear commented 8 years ago

@tschottdorf You're awesome!

Hoverbear commented 8 years ago

Awesome. I'm going to ask @homu to merge this. Thanks for the contribution! Feel encouraged and welcome to add yourself to the contributors field in the Cargo.toml

Hoverbear commented 8 years ago

@homu r+

homu commented 8 years ago

:pushpin: Commit 505b2fc has been approved by Hoverbear

homu commented 8 years ago

:hourglass: Testing commit 505b2fc with merge 0244184...

homu commented 8 years ago

:broken_heart: Test failed - status

Hoverbear commented 8 years ago

Dependency issues. Let's try again tomorrow. :)

homu commented 8 years ago

:sunny: Test successful - status

Hoverbear commented 8 years ago

It worked early!