Fix Catchup - Githubissues

Hoverbear / old-raft-rs

[Incomplete] A Raft implementation in Rust

https://hoverbear.github.io/raft-rs/raft/

MIT License

266 stars 41 forks source link

Fix Catchup #99

Closed Hoverbear closed 8 years ago

Hoverbear commented 8 years ago

(Closes #97, much more info there)

Steps to reproduce:

cd experiments/tmux/hashmap-local-3
./dashboard to get 4 tabs.
In Server 1 RUST_LOG=raft::consensus=debug ./server 1
In Server 2 RUST_LOG=raft::consensus=debug ./server 2
In Server 3 RUST_LOG=raft::consensus=debug ./server 3
In Command Seat ./put foo bar a few times (doesn't matter really)
Look for the leader in the servers, kill it.
Restart the leader after a moment.
Observe looping behaivor.

This fixes is by:

Having append_entries carry the entry terms as well.
Correctly reporting back the right index.

@danburkert please review. :)

danburkert commented 8 years ago

Looks good to me! r+ once you take in @tschottdorf's comments.

danburkert commented 8 years ago

@homu r+

homu commented 8 years ago

:pushpin: Commit 0079a07 has been approved by danburkert

homu commented 8 years ago

:hourglass: Testing commit 0079a07 with merge cf44087...

Hoverbear commented 8 years ago

@homu r=danburkert

homu commented 8 years ago

:pushpin: Commit d0a32d3 has been approved by danburkert

homu commented 8 years ago

:hourglass: Testing commit d0a32d3 with merge f8bafc7...

homu commented 8 years ago

:sunny: Test successful - status