search

How-Bout-No / Outvoted

Outvoted is a Minecraft mod that adds in mobs from previous mob votes that weren't able to make it into the game, trying to stay true to the original concepts.
GNU General Public License v3.0
22 stars 10 forks source link

[BUG] The guide book can't be obtained on [FABRIC] Outvoted-1.5.0-beta.1 #95

Closed SplendidAlakey closed 2 years ago

SplendidAlakey commented 2 years ago

/Before submitting, please ensure you've done the following, as these are fixes for some common bugs: [✔] Reset/delete config files [✔] Run without mods like Optifine (if needed) [✔] Double check that you have the latest version!!

Describe the bug

When trying to craft an Outvoted guide book by combining a lava bucket with a book, no output is given. The book also fails to be given on spawn. It also doesn't exist in the /give command output. The only way I found to obtain the book was with some of my mods (I'm not sure which ones, because I have so many of them), that allow you to see unobtainable items in the creative inventory. However, the book itself is broken.

To Reproduce

Steps to reproduce the behavior:

  1. Install Fabric API, Architectury, Cloth config, GeckoLib and Outvoted
  2. Launch the game and create a new world or enter an old one
  3. No guide book is given on spawn
  4. Try to craft the book by combining a lava bucket and a book and see that there's no output

Screenshots/Logs

[removed]

Broken book: 2021-10-25_20 50 56 2021-10-25_20 51 00

Version (please complete the following information):

Additional context

Tested the issue without any other mods loaded, apart from FAPI and Outvoted's dependencies.

How-Bout-No commented 2 years ago

Oh... odd. I guess that's one thing I missed, since in dev it's always broken but outside of dev it always seemed to work. Will work on a fix.

Edit: It actually looks like 2.0 patchouli entries are in 1.5, hoping that's the only reason it's broken...

How-Bout-No commented 2 years ago

Book issues should be fixed in beta 2, at least on new logins players are given a book and the book opens without problems.

Also, due to the way Patchouli works (or maybe the way I'm using Patchouli) the command to give a book would be /give whoever patchouli:guide_book{"patchouli:book": "outvoted:book"} as the book is dependent on Patchouli and not it's own unique item within the mod, if that makes sense.