search

How-Bout-No / Outvoted

Outvoted is a Minecraft mod that adds in mobs from previous mob votes that weren't able to make it into the game, trying to stay true to the original concepts.
GNU General Public License v3.0
22 stars 10 forks source link

[BUG] Client crashes upon using a Honeycomb on a Copper golem due to a mod conflict #96

Closed SplendidAlakey closed 2 years ago

SplendidAlakey commented 3 years ago

/Before submitting, please ensure you've done the following, as these are fixes for some common bugs: [✔] Reset/delete config files [✔] Run without mods like Optifine (if needed) [✔] Double check that you have the latest version!!

Describe the bug

When having a lot of mods loaded together with Outvoted, the client crashes upon using a Honeycomb on a Copper golem when playing on a server.

With all my mods I consistently get a crash after using a Honeycomb on a Copper golem, with just Outvoted everything works as intended.

Only the client crashes, server keeps working. In single player no crash happens with the same exact mods. I also don't see any related logs in the latest.log of the server.

To Reproduce

  1. Have all the mods I do on both the client and the server
  2. Join the server and try to use a Honeycomb on a Copper golem
  3. Client will crash, server will not

Screenshots/Logs

[removed]

Version (please complete the following information):

Additional context

My modpack is pretty big so going through every mod 1 by 1 would be very time consuming, so I'm hoping these logs could help identify the issue.

How-Bout-No commented 3 years ago

I'll see if I can narrow down the issue. Seeing as this is a client only crash, it should be easier to deduce.

How-Bout-No commented 3 years ago

Also is this a modpack on CurseForge or is this one you setup? Cause it would be easier for me to pick apart that way

SplendidAlakey commented 3 years ago

It's my own custom modpack. I based it on Better Minecraft and All Of Fabric 4, but I have some mods they don't and vice versa.

How-Bout-No commented 3 years ago

Would you be able to test this jar? Considering this is a client crash it should probably only be needed on the client (assuming it works :P) outvoted-1.5.0-b2.zip

SplendidAlakey commented 3 years ago

It works. The crash doesn't happen anymore. Thank you!

I noticed that now they can only be waxed once (could be waxed infinitely before), which I would guess was the issue?

How-Bout-No commented 3 years ago

Actually, that's a separate bug that I also fixed in this dev version lol. I believe the problem was that code for the axe interaction was accidentally used for the Honeycomb (and copper ingot too) and so it was trying to damage the Honeycomb item when it couldn't? Theoretically this should also probably crash the server too but maybe I just don't get it. I also went and removed some ambiguity between clients and servers in some separate code which seems to have no side effect but this I'll need to test myself.

How-Bout-No commented 2 years ago

Fixed in public beta 2