Oxidized Copper Golems reset pose after rejoin on single player[BUG]

[frikinjay]

/Before submitting, please ensure you've done the following, as these are fixes for some common bugs: [ ] Reset/delete config files [ ] Run without mods like Optifine (if needed) [ ] Double check that you have the latest version!!

Describe the bug Oxidized Copper Golems reset pose after rejoin on single player.

To Reproduce Steps to reproduce the behavior:

1. Create a single player world.
2. Spawn a copper golem.
3. Wait for it to oxidize.
4. Leave the world and rejoin.

Screenshots/Logs Before

After

Version (please complete the following information):

• 1.17.1
• Fabric
• 1.5.0-beta.1

Additional context

[How-Bout-No]

Oh what. Wondering what caused this to break. Can you confirm if it only happens in singleplayer?

[frikinjay]

I havent tried it on a server, but i can confirm it happens on single player.

[SplendidAlakey]

It happens on servers too.

Before restart:

After:

There's also a Mob Catcher mod that makes it very easy to replicate without restarting. Just catch fully oxidized golems and place them down, they will change stances every single time.

[How-Bout-No]

Somewhat fixed in beta 2, however it needs a bit more work due to client/server desync so I'm leaving this open until then.

Here's the current issue: if the Golem oxidizes and then rotates after it's frozen, then its actual position/rotation is where it was before it rotated (as this rotation only happens on the client side). The client gets updated with the server values on relog, but I'm working on a way to get them properly synced. Still, this is a big improvement over the poses not saving at all, but it obviously still needs a bit of tweaking. If the Golem does not rotate after it oxidizes then the client and server should have the same position.

[How-Bout-No]

Closing this now since any desync in the current versions seems to be sufficiently corrected.