HowProgrammingWorks / NodejsStarterKit

Starter Kit for Node.js 16 or later, minimum dependencies 🚀
http://metarhia.com
MIT License
463 stars 102 forks source link

Server class does not receive a port information #204

Open Max-im opened 1 year ago

Max-im commented 1 year ago

In order to init the Server class, 2 arguments are passed (config.server and options) in the second argument (options) there are 3 values (cert, Chanel and app instance). however, Chanel and the app instance require directly in the Server class file.

  1. during Server class initialization port info does not pass into the class and the server has no chance to start correctly
  2. Chanel requires incorrectly, it exports like module.exports = Chanel but requires like const { Chanel } = require(../) please lose curly braces here
  3. application requires incorrectly, it exports like module.exports = application but requires like const { application } = require(../) please lose curly braces here