Howard86 / next-api-handler

lightweight nextjs api handler wrapper, portable & configurable for serverless environment

https://next-api-handler.vercel.app

Other

50 stars 1 forks source link

Fix compatibility caused by type definition #16

Closed Howard86 closed 2 years ago

Howard86 commented 2 years ago

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Bug fix: this package introduced a lot of custom types that conflicted with next.js built-in type

What is the current behavior? (You can also link to an open issue here)

lots of custom type (type alias & interface)

What is the new behavior (if this is a feature change)?

extend next.js built-in interface and use any for internal type-checking (should not affect library users) also removed lots of existed type

Other information:

This PR will introduce breaking changes on next-api-handler type definition, make sure to run type check after upgrade (e.g. tsc --noEmit)

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/howard86/next-api-handler/A6DJqZCJMVrtZL4mkXBcnjyLhZPN
✅ Preview: https://next-api-handler-git-bugfix-type-definition-inc-d2a804-howard86.vercel.app

codecov[bot] commented 2 years ago

Codecov Report

Merging #16 (4965f99) into main (ff2d4f1) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #16   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines           98        98           
  Branches        11        11           
=========================================
  Hits            98        98

Impacted Files	Coverage Δ
src/lib/error-handler.ts	`100.00% <ø> (ø)`
src/lib/router.ts	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ff2d4f1...4965f99. Read the comment docs.

cypress[bot] commented 2 years ago

Test summary

11 • 0 • 0 • 0

Run details


Project	next-api-handler
Status	Passed
Commit	4965f998ab
Started	Jan 1, 2022 9:58 AM
Ended	Jan 1, 2022 9:58 AM
Duration	00:19 💡
OS	Linux Debian - 10.8
Browser	Electron 94

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard