iamsaywhat
commented
2 years ago It looks like this was an attempt to fix #690? Is there any reason you deleted this PR @iamsaywhat?
Yep, I wanted to prepare this PR better, but I accidentally opened it prematurely. And I haven't found time to do it again yet. BTW, we use these fixes in our project on Windows, and at least under MSVC it works well. Looks like I don't have to do that anymore now because you opened #690 🙂
It looks like this was an attempt to fix #690? Is there any reason you deleted this PR @iamsaywhat?
I would love to get this fixed, I've had at least 3 Windows users run into this problem 😢 (https://github.com/r-lib/tzdb/issues/10).
Now that the tzdb package (which embeds date) is used in the more popular readr R package for reading delimited files into R, I have a feeling I will be seeing issues with this more often :/