HowardHinnant / date

A date and time library based on the C++11/14/17 <chrono> header
Other
3.08k stars 670 forks source link

Sync implementation and header signatures #724

Closed DavisVaughan closed 2 years ago

DavisVaughan commented 2 years ago

A user pointed out in https://github.com/r-lib/tzdb/pull/19 that two signatures are out of sync (and apparently only these two, according to their build tools). This PR just syncs them back up.

set_install

I chose to go with install here, as that seemed more informative.

https://github.com/HowardHinnant/date/blob/3776e0f18562b8813a8733aed3677e01e960a5a2/include/date/tz.h#L1300

https://github.com/HowardHinnant/date/blob/3776e0f18562b8813a8733aed3677e01e960a5a2/src/tz.cpp#L418

get_info_impl

I chose to go with tz_int here, because in the implementation you perform a static cast of this int tz_int object to a tz timezone and that "real" tz object feels like it should have the better name.

https://github.com/HowardHinnant/date/blob/3776e0f18562b8813a8733aed3677e01e960a5a2/include/date/tz.h#L848

https://github.com/HowardHinnant/date/blob/3776e0f18562b8813a8733aed3677e01e960a5a2/src/tz.cpp#L2611-L2615