search

HowardHinnant / date

A date and time library based on the C++11/14/17 <chrono> header
Other
3.14k stars 677 forks source link

Is files[] up to date? #737

Open andreygorbachevrabobank opened 2 years ago

andreygorbachevrabobank commented 2 years ago

Dear Sir/Madam,

I assume this variable lists data files from the tzdata downloadable. At the moment of writing that would be of the version 2022a. I think that the variable initialisation might have got our of sync with the tzdata2022a content, would you consider fixing it please?

Thank you, Andrey

HowardHinnant commented 2 years ago

Just to make sure I'm understanding your comment, are you referring to the fact that the file systemv is no longer being distributed?

andreygorbachevrabobank commented 2 years ago

Yes, also pacificnew is not there any more I think. And I am not 100% sure if there are any new (additional) files which should be attempted to be loaded there now.

Thank you for getting back to me that quickly – your help is appreciated.

From: Howard Hinnant @.> Sent: 19 May 2022 18:08 To: HowardHinnant/date @.> Cc: Gorbachev, A (Andrey) @.>; Author @.> Subject: Re: [HowardHinnant/date] Is files[] up to date? (Issue #737)

Just to make sure I'm understanding your comment, are you referring to the fact that the file systemv is no longer being distributed?

— Reply to this email directly, view it on GitHubhttps://github.com/HowardHinnant/date/issues/737#issuecomment-1131968839, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AZHZAYKTXCGFLSZNFDY4A6DVKZYONANCNFSM5WM2ZSGQ. You are receiving this because you authored the thread.Message ID: @.***>

This email (including any attachments to it) is confidential, legally privileged, subject to copyright and is sent for the personal attention of the intended recipient only. If you have received this email in error, please advise us immediately and delete it. You are notified that disclosing, copying, distributing or taking any action in reliance on the contents of this information is strictly prohibited. Although we have taken reasonable precautions to ensure no viruses are present in this email, we cannot accept responsibility for any loss or damage arising from the viruses in this email or attachments. We exclude any liability for the content of this email, or for the consequences of any actions taken on the basis of the information provided in this email or its attachments, unless that information is subsequently confirmed in writing. <#rbnl#1898i>

HowardHinnant commented 2 years ago

Ah, thanks, I missed pacificnew. Yes, I'll remove these two from files[].

andreygorbachevrabobank commented 2 years ago

Cool, thank you. Do you think any new files should be taking their place? (I do not know enough about tzdata trajectory to understand this unfortunately).

From: Howard Hinnant @.> Sent: 19 May 2022 18:29 To: HowardHinnant/date @.> Cc: Gorbachev, A (Andrey) @.>; Author @.> Subject: Re: [HowardHinnant/date] Is files[] up to date? (Issue #737)

Ah, thanks, I missed pacificnew. Yes, I'll remove these two from files[].

— Reply to this email directly, view it on GitHubhttps://github.com/HowardHinnant/date/issues/737#issuecomment-1131989880, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AZHZAYJAUDC7FJLF6WM24ZTVKZ25LANCNFSM5WM2ZSGQ. You are receiving this because you authored the thread.Message ID: @.***>

This email (including any attachments to it) is confidential, legally privileged, subject to copyright and is sent for the personal attention of the intended recipient only. If you have received this email in error, please advise us immediately and delete it. You are notified that disclosing, copying, distributing or taking any action in reliance on the contents of this information is strictly prohibited. Although we have taken reasonable precautions to ensure no viruses are present in this email, we cannot accept responsibility for any loss or damage arising from the viruses in this email or attachments. We exclude any liability for the content of this email, or for the consequences of any actions taken on the basis of the information provided in this email or its attachments, unless that information is subsequently confirmed in writing. <#rbnl#1898i>

HowardHinnant commented 2 years ago

I looked and didn't see any. But then again I missed pacificnew. ;-) If any file contains a non-commented-out keyword Rule, Link, Leap or Zone, we should consider including it.

andreygorbachevrabobank commented 2 years ago

I had a look at the files once more (with fresh eyes) and there might be 2 other files to be considered (not sure if they are new for 2022a - have not checked the older releases, just read through the 2022a files following your list of keywords):

1) "backzone" - but probably that is out of scope of what you want to do.

and

2) "factory" - which should assist with (consistent) default settings.