HowardHinnant / date

A date and time library based on the C++11/14/17 <chrono> header
Other
3.14k stars 675 forks source link

Include additional headers during cmake install #795

Open pabiswas opened 1 year ago

pabiswas commented 1 year ago

cmake install only copies date/date.h in the installation path. This PR adds the other headers in the installation path during cmake install.

basilgello commented 2 days ago

This is useful change and it closely resembles the one Debian uses and I am using in Kodi (yet this change might need CMake older than 3.15). I am now going to check if this PR works as expected with current CMake and CMake < 3.15 before I mark it as ready.

basilgello commented 1 day ago

Great! Although not principal, the changed line should be indented for better readability. I dont know why Android client app for Github that I use has chewed leading spaces :(

basilgello commented 13 hours ago

@HowardHinnant can be merged with indentation fix :)

HowardHinnant commented 10 hours ago

I'm not comfortable making this change. It isn't that I don't like the change. It is that I don't understand the git process well enough to be assured I will make the change without messing it up.

basilgello commented 6 hours ago

Moment, let me do the branch off it and show how it should look like!

basilgello commented 6 hours ago
git checkout master
git pull
git fetch https://github.com/basilgello/date include-headers
git merge --ff FETCH_HEAD

Branch: https://github.com/basilgello/date/commits/include-headers