search

HowardHinnant / date

A date and time library based on the C++11/14/17 <chrono> header
Other
3.14k stars 675 forks source link

Prepending CMake options dith DATE_ #806

Closed pbosetti closed 1 day ago

pbosetti commented 8 months ago

This way, when the library is integrated into another project e.g. with CMake FetchContent, options for date lib are cleanly grouped together in ccmake or make-gui

basilgello commented 2 days ago

I like the overall idea but for a minor bump that might be considered a breaking change. An alternative might be to check if "old" settings are used and issue a CMake Warning stating the deprecation.

@HowardHinnant what is your opinion?

HowardHinnant commented 1 day ago

I don't want to make any breaking changes. This library is obsoleted by C++20 and should slowly fade away with as little noise as possible.