search

Hpmason / retour-rs

A cross-platform detour library written in Rust
Other
99 stars 18 forks source link

fix: remove feature requirement for thiscall #34

Closed ElonGaties closed 8 months ago

ElonGaties commented 10 months ago

abi_thiscall is now considered stable by rust https://github.com/rust-lang/rust/commit/06daa9e263db87b3c5d4d80110938130db846183

Hpmason commented 10 months ago

Thanks for helping update this with the recent stabilization!

Though it's stabilized, it's not planned to be released until 1.73.0 on October 5th. So until the official toolchain release, I'd like to keep that under the feature flag, that way current users on stable can still compile.

In order to fix the issue with the nightly feature, the lib.rs file is what actually needs to be changed to remove the cfg_attr for thiscall-abi flag here:

https://github.com/Hpmason/retour-rs/blob/master/src/lib.rs#L11-L14

ElonGaties commented 10 months ago

I have removed that definition, perhaps once thiscall abi can be used on stable this could be pushed.