search

HriBB / graphql-server-express-upload

Graphql Server Express file upload middleware
MIT License
41 stars 5 forks source link

Add multer to peer dependencies #1

Closed sandervanhooft closed 8 years ago

sandervanhooft commented 8 years ago

@HriBB After reading the docs and checking package.json, I'd suggest to add multer to the peer dependencies.

thebigredgeek commented 8 years ago

@sandervanhooft peerDependencies are deprecated in npm 3. I don't think we should add them

sandervanhooft commented 8 years ago

Ok, good to know :). Perhaps as a dependency then? It's not included by the Apollo stack as far as I know.

On Thu, 1 Dec 2016 at 06:23 Andrew E. Rhyne notifications@github.com wrote:

@sandervanhooft https://github.com/sandervanhooft peerDependencies are deprecated in npm 3. I don't think we should add them

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/HriBB/graphql-server-express-upload/issues/1#issuecomment-264081774, or mute the thread https://github.com/notifications/unsubscribe-auth/AG7dp8_PYrelyXB7StTIFz7Q6se9WFUCks5rDlmygaJpZM4LAI4N .

HriBB commented 8 years ago

We can add it as a dependency. Again, want to make a PR? Otherwise I will fix this next week ... hopefully :)

sandervanhooft commented 8 years ago

I'm using "multer": "^1.2.0", will try to make a PR soon

thebigredgeek commented 8 years ago

I honestly dont know if adding it as a dependency is the correct approach, unless we also bind the middleware ourselves within the apollo upload middleware. That might actually be the ideal solution here