Added body-parser, graphql, multer to dependencies

HriBB / graphql-server-express-upload

Graphql Server Express file upload middleware

MIT License

41 stars 5 forks source link

Added body-parser, graphql, multer to dependencies #6

Closed sandervanhooft closed 7 years ago

sandervanhooft commented 7 years ago

Not sure if it's complete now. Relates to issues #1, #2 and #3.

HriBB commented 7 years ago

Merged! Thanks @sandervanhooft

thebigredgeek commented 7 years ago

Hmm not sure if this is actully the correct approach. BodyParser isn't required by this package. It seems kind of hacky to handle it this way

HriBB commented 7 years ago

@thebigredgeek I think you're right. People might use a different body parser or a different middleware than multer to process uploaded files. But I'm not sure about graphql.

Anyway, I'm very new to the whole npm ecosystem. I don't have much experience with maintaining open-source libraries yet, so any help is greatly appreciated. What do you suggest we do in this case?