Refactor code issue #55

HridoyHazard / BetterColor

A Simple Project For BetterColor Readability. You Can Easily Choice Best Color Readability For Any Background.

https://hridoyhazard.github.io/BetterColor/

MIT License

26 stars 61 forks source link

Refactor code issue #55 #64

Closed jsapuyesp closed 2 years ago

jsapuyesp commented 2 years ago

The Problem/Feature

Problems in the code, because all the app was inside the <header></header> tag.

Implementation details

All coding in the app, i change the Home.html and the Home.css class and tags

Checklist:

[ x ] Pull Request title is good
[ x ] Commit message is good (copy the Pull Request description to the commit message)
[ x ] Tested code locally
[ ] Covered by automated tests
[ ] Approved by the author

jsapuyesp commented 2 years ago

About the update of the app: imagen

The app it was separated in 3 sections: <header></header>, <main></main>, <footer></footer>

imagen

And the css code is refactored too...

HridoyHazard commented 2 years ago

fix your conflicts first

jsapuyesp commented 2 years ago

The conflicts it was solved!

HridoyHazard commented 2 years ago

i can't merge it due to conflicts can you plz check and fix the desired conflicts which you're creating

jsapuyesp commented 2 years ago

The problem happens because you first accept other PR that affect the code I am refactoring, please check this PR first before the others to avoid these conflicts!