netlify[bot]
commented
1 year ago Deploy Preview for effulgent-brioche-795ac4 ready!
| Name | Link |
|---|---|
| Latest commit | a5ccb433b12d5ed26ae8032f4c5bc28bfcd8e56d |
| Latest deploy log | https://app.netlify.com/sites/effulgent-brioche-795ac4/deploys/63549e5e2e6cd700083bcf19 |
| Deploy Preview | https://deploy-preview-84--effulgent-brioche-795ac4.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
This Pull Request is made for the issue #75 in which the app is dockerized using Docker and being ready to use either for development (using npm run start) and production (using npm run build and later being deployed into a nginx web server). Also I've modified the README to explain the commands used for building and running and also I've made a Makefile to make the execution kinda easy
The only problem with this is that Docker can insert environment variables into the containers but using the production container is not possible to insert them in runtime because the npm run build command needs the variables for building the static files, so you cannot pass new variables after building and to make it work, the .env file must be present into the container for building. There's a solution to pass variables after building during runtime but I haven't implemented here, maybe in a future Pull Request
Maybe there are some fixes or new feature that other people can implement like a code to deploy directly into AWS or GCP, or integrate the container into Kubernetes or Docker Swarm