search

Hrishi1999 / Dashboard.activity

Part of GSoC 2019 work. A Dashboard activity for Sugar users.
GNU General Public License v3.0
2 stars 3 forks source link

Display Issues #1

Closed chimosky closed 5 years ago

chimosky commented 5 years ago

Ran activity and the stop button isn't showing, when I click on a particular day in the heatmap that has a lot of entries the window isn't scrollable.

Are activity instances supposed to be shown as files?. Should that be restricted to files of a particular mime type, as the terminal activity has no mime type but shows as a file.

You've done a great job, thanks.

Hrishi1999 commented 5 years ago

Thanks for testing. What is your display resolution? The scrollbar isn't being displayed because of the tree view being stretched. Will fix it.

chimosky commented 5 years ago

Thanks for testing. What is your display resolution?

16:9

Are activity instances supposed to be shown as files?. Should that be restricted to files of a particular mime type, as the terminal activity has no mime type but shows as a file.

Can you answer this, thanks.

Hrishi1999 commented 5 years ago

This activity was made with a 1280x720 display. It should support higher resolutions, but I haven't tested on lower resolution after some changes.

Terminal activity, Chat activity are both shown as files. I could try to filter them out tomorrow (or find mime type which is responsible)

quozl commented 5 years ago

Please test on all common resolutions and aspect ratios. Minimum for compatibility with Fedora 18 OLPC XO is 1200x900.

Hrishi1999 commented 5 years ago

I've tested a couple of resolutions now (1152x864, 1280x720, 1200x900, 1600x900) and I couldn't seem to reproduce yet. Can you test again @chimosky (also, in the latest commit, active heatmap tiles are green, not blue so I guess you were testing on an older commit)? Thanks a lot!

quozl commented 5 years ago

Also test resizing displays. This happens when an external monitor is plugged into a laptop, or when a virtual machine window is resized by the user.

chimosky commented 5 years ago

I've tested a couple of resolutions now (1152x864, 1280x720, 1200x900, 1600x900) and I couldn't seem to reproduce yet. Can you test again @chimosky (also, in the latest commit, active heatmap tiles are green, not blue so I guess you were testing on an older commit)? Thanks a lot!

Tested and issue still persists but there's a slight difference now, when I select Files no items show as I have none but the stop button becomes visible but selection or All or Older hides it. My vm screen resolution is 1366x694.

Hrishi1999 commented 5 years ago

I've fixed the TreeView column size issue. I ellipsized the title, the full title is visible as a tooltip. Please test the recent changes. Thanks :)

chimosky commented 5 years ago

Just tested, activity works as intended. Nice work. Thanks.