search

HristoKolev / TvDbSharper

TvDbSharper is fully featured modern REST client for the TheTVDB API v4
MIT License
29 stars 17 forks source link

v4 API #25

Open ittroll opened 3 years ago

ittroll commented 3 years ago

TheTVDB have launched v4 of their API. Access to this now requires a paid subscription and they have said they intend to deprecate all previous API versions in a couple of months. :-(

I was wondering if you are planning to update TvDbSharper to support the new v4 API.

https://app.swaggerhub.com/apis-docs/thetvdb/tvdb-api_v_4/4.0.0

HristoKolev commented 3 years ago

I know about this, of course.

Some time ago I planned to create a v4 version of this library in some form or another. At the time the v4 authentication process was not documented on the swagger page or anywhere else, so nobody could actually test against the API. It was basically unusable on release and for some time afterwards.

I see now that there is a /login request in the swagger docs page so I plan to at least try to make it work.

There are some questions that I still don't have an answer for, but I will try to find out more.

ittroll commented 3 years ago

That is great news and much appreciated. Good luck with your endeavours.

ittroll commented 3 years ago

Looks like the ongoing issues with the v4 API means the older APIs will live on for a bit longer.

“Due to a myriad of issues with the v4 API, we will be extending the cutoff date for all of our older APIs. The new cutoff date will now be October 1, 2021.” - TheTVDB.com

ghost commented 3 years ago

So what is the latest on converting this library to work with v4api? I just got an email from TvDb stating eveything other than v4 would stop working on 10/2/2021.

HristoKolev commented 3 years ago

Last time I checked (a few months ago) the API wasn't usable yet. I'll check again.

ghost commented 3 years ago

Thanks for the quick reply. They seem to think it is, as they have said v3 will no longer be supported as of 10/2/2021.

ghost commented 3 years ago

Here is a copy of the email I received from them this morning:

Hi TheTVDB Community Member,

As you likely know, a few months ago we released the latest version of our API, affectionately known as v4. Since then, TheTVDB team has been hard at work cranking out new features like expanded search, as well as developing additional endpoints and support tools for our developer community.

Given these recent improvements, we wanted to encourage all of our developers to upgrade to v4 if they haven’t already. And to help with that, we have pushed the deadline for sunsetting our legacy APIs to October 1, 2021. You will have until then to ensure your project is fully operating on the v4 API.

Additionally, our public GitHub is now officially open! You can submit support issues and connect directly with TheTVDB’s developers in our v4 API repo.

Take Me to GitHub

We’ve also just released a Python wrapper for the v4 API, which developers can now make use of. The wrapper is currently in beta, and can be found in our GitHub repo.

From: Hristo Kolev @.*** Sent: Friday, August 13, 2021 2:06 PM To: HristoKolev/TvDbSharper Cc: cmh31909; Comment Subject: Re: [HristoKolev/TvDbSharper] v4 API (#25)

Last time I checked (a few months ago) the API wasn't usable yet. I'll check again.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/HristoKolev/TvDbSharper/issues/25#issuecomment-898632428 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AIE4UFSRQNTYGFIJSCXLOYDT4VNHHANCNFSM4W7K5DJA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email . https://github.com/notifications/beacon/AIE4UFWTSXTDJ4PCN7WYHSLT4VNHHA5CNFSM4W7K5DJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOGWIAV3A.gif

HristoKolev commented 3 years ago

Yeah. How do you subscribe for these emails? I haven't personally used the API for 4 years, kinda lost connection with these people, especially after they deleted the forums and the gitlab instance because people were complaining.

ghost commented 3 years ago

I had to give them an email address when I obtained an ApiKey to call their api. They sent the email to that address.

ghost commented 3 years ago

The original email came in from: TheTVDB support@thetvdb.com When I responded to that, I got an email back from Emily Helwig ehelwig@whipmedia.com

HristoKolev commented 3 years ago

Interesting.

ittroll commented 3 years ago

It is rather annoying that they still haven't made the promised free subscription available to people who contribute data.

It would be great to get TvDbSharper updated for v4 though. If they are sending out emails it looks like they are really going to turn off of the legacy APIs this time.

HristoKolev commented 3 years ago

I'll start work in it as soon as I can. :)

On Sat, Aug 14, 2021, 09:57 ittroll @.***> wrote:

It is rather annoying that they still haven't made the promised free subscription available to people who contribute data.

It would be great to get TvDbSharper updated for v4 though. If they are sending out emails it looks like they are really going to turn off of the legacy APIs this time.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/HristoKolev/TvDbSharper/issues/25#issuecomment-898848353, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADI4PRGZFKFTFKLOP3P3TWDT4YHVDANCNFSM4W7K5DJA .

HristoKolev commented 3 years ago

I started work on the v4 rewrite. Do we know what if we have the language header implemented yet? That's something that's in v3 but missing in v4.

HristoKolev commented 3 years ago

Just uploaded the v4.0.0 package. It has all endpoints but I didn't have any time for tests or documentation. I manually tested the authentication endpoint and a few of the others.

When have the time I will:

Things still missing:

I need some help with feeding this with real data and seeing where it will fail.

I haven't had a use for this package in 4 years so I need someone else to report these issues to me. I'll make time to fix them.

ittroll commented 3 years ago

This is great news, many thanks. I am not a developer, but I work with a developer on a small community project which makes use of TvDbSharper. We’ll be sure to test this out and let you know,

HristoKolev commented 3 years ago

I pushed an update. Methods shouldn't throw exceptions anymore except for a few of the translation endpoints that throw on the server.

shanemartin913 commented 3 years ago

Are there any examples for those of us who do not commonly use a REST library? How to get a series or episodes...

HristoKolev commented 3 years ago

The closest thing to a list of examples right now is this:

https://github.com/HristoKolev/TvDbSharper/blob/master/test/ManualTests/Program.cs