HstarComponents / ngx-ckeditor

The CKEditor component for angular
https://hstarcomponents.github.io/ngx-ckeditor/
MIT License
22 stars 22 forks source link

Angular 7 - cannot import js file, script tag gets removed #48

Closed phil123456 closed 5 years ago

phil123456 commented 5 years ago

hello,

I try to add to my index.html but it gets removed

if I donwload the "ckeditor.js" and put it in my assets folder, loading it with angular.json "scripts" entry point, then the script loads but it cannot find languages and css files

can you update your documentation for angular 7 ?, aparently it does not work anymore

regards

{
  "name": "editor-test",
  "version": "0.0.0",
  "scripts": {
    "ng": "ng",
    "start": "ng serve",
    "build": "ng build",
    "test": "ng test",
    "lint": "ng lint",
    "e2e": "ng e2e"
  },
  "private": true,
  "dependencies": {
    "@angular/animations": "~7.1.0",
    "@angular/common": "~7.1.0",
    "@angular/compiler": "~7.1.0",
    "@angular/core": "~7.1.0",
    "@angular/forms": "~7.1.0",
    "@angular/platform-browser": "~7.1.0",
    "@angular/platform-browser-dynamic": "~7.1.0",
    "@angular/router": "~7.1.0",
    "core-js": "^2.5.4",
    "ngx-ckeditor": "^0.4.0",
    "rxjs": "~6.3.3",
    "tslib": "^1.9.0",
    "zone.js": "~0.8.26"
  },
  "devDependencies": {
    "@angular-devkit/build-angular": "~0.11.0",
    "@angular/cli": "~7.1.0",
    "@angular/compiler-cli": "~7.1.0",
    "@angular/language-service": "~7.1.0",
    "@types/node": "~8.9.4",
    "@types/jasmine": "~2.8.8",
    "@types/jasminewd2": "~2.0.3",
    "codelyzer": "~4.5.0",
    "jasmine-core": "~2.99.1",
    "jasmine-spec-reporter": "~4.2.1",
    "karma": "~3.1.1",
    "karma-chrome-launcher": "~2.2.0",
    "karma-coverage-istanbul-reporter": "~2.0.1",
    "karma-jasmine": "~1.1.2",
    "karma-jasmine-html-reporter": "^0.2.2",
    "protractor": "~5.4.0",
    "ts-node": "~7.0.0",
    "tslint": "~5.11.0",
    "typescript": "~3.1.6"
  }
}
hstarorg commented 5 years ago

The document are used angular 7.x. I think you should check your build progress.

phil123456 commented 5 years ago

The document are used angular 7.x. I think you should check your build progress.

I know all the words in this phrase , yet I dont understand what you're trying to communicate I'll try updating my project if it's what you mean ;-)

hstarorg commented 5 years ago

Sorry, my English is a little poor.
The repo demo url(https://hstarcomponents.github.io/ngx-ckeditor/) are build with angular 7.x and ckedtior 4.9.1, it works fine.

hstarorg commented 5 years ago

ngx-ckeditor@8.0.0 for angular 8.x released.

phil123456 commented 5 years ago

just updated , it simply does not work it cannot even find the files on the CDN...

https://i.imgur.com/b7PGdBe.png ( I tried with the "/full" and without it, seems these files dont even exist)

I tried setting it up in the app component html

<script src="//cdn.ckeditor.com/4.7.1/full/ckeditor.js"></script>
<ck-editor name="editor1" [(ngModel)]="editorValue" skin="moono-lisa" language="en" [fullPage]="true"></ck-editor>

it's just not appearing in the final html page, it gets removed

what the actual f..????

hstarorg commented 5 years ago

Why not see my demo : https://github.com/HstarComponents/ngx-ckeditor/tree/master/examples If you can't find ckeditor in cdn, you can download it on your project.

phil123456 commented 5 years ago

ok I finaly found the issue the script tag must be in index.html, not app.component.html my bad

hstarorg commented 5 years ago

That's good.