HttpRafa / creeper-recover

Recovers all destroyed blocks by Creeper or other Entities
MIT License
6 stars 0 forks source link

Plugin not working with 1.21? #26

Open schroding3r opened 3 months ago

schroding3r commented 3 months ago

I've got the plugin installed on Spigot, and I can trigger fixes manually using /recover fix all, but it doesn't seem like it's recovering automatically after the 100ms.

Edit: I've noticed with testing it will replace lanterns...this is the only item I've found that currently is replaced after destruction.

It's possible I've missed something, but I believe the config out of the box should work for creepers, right?

HttpRafa commented 3 months ago

Are you getting errors in the console?

HttpRafa commented 3 months ago

But look at the config again if the functions are activated the way you want them to be, also check if the filter enabled is set to true.

schroding3r commented 3 months ago

Not seeing any errors in the console, no. The only target I have enabled is type ENTITY, included below. It works fine if I run the fix command, exactly as expected, but it seems to refuse to do it automatically.

{ "configVersion": 2, "plugin": { "enabled": true, "bStats": true, "ignoreUpdates": false }, "recover": { "recoverSpeed": 1, "recoverDelay": 1, "blockRecoverSound": "BLOCK_ROOTED_DIRT_PLACE", "blockBlacklist": [] }, "target": [ { "type": "ENTITY", "ignore": false, "entityTypes": [ "CREEPER", "PRIMED_TNT" ] } ] }

HttpRafa commented 3 months ago

Not seeing any errors in the console, no. The only target I have enabled is type ENTITY, included below. It works fine if I run the fix command, exactly as expected, but it seems to refuse to do it automatically.

{ "configVersion": 2, "plugin": { "enabled": true, "bStats": true, "ignoreUpdates": false }, "recover": { "recoverSpeed": 1, "recoverDelay": 1, "blockRecoverSound": "BLOCK_ROOTED_DIRT_PLACE", "blockBlacklist": [] }, "target": [ { "type": "ENTITY", "ignore": false, "entityTypes": [ "CREEPER", "PRIMED_TNT" ] } ] }

Ok, I'll take a look at it if I can reproduce it.

HttpRafa commented 3 months ago

Not seeing any errors in the console, no. The only target I have enabled is type ENTITY, included below. It works fine if I run the fix command, exactly as expected, but it seems to refuse to do it automatically. { "configVersion": 2, "plugin": { "enabled": true, "bStats": true, "ignoreUpdates": false }, "recover": { "recoverSpeed": 1, "recoverDelay": 1, "blockRecoverSound": "BLOCK_ROOTED_DIRT_PLACE", "blockBlacklist": [] }, "target": [ { "type": "ENTITY", "ignore": false, "entityTypes": [ "CREEPER", "PRIMED_TNT" ] } ] }

Ok, I'll take a look at it if I can reproduce it.

I have checked it several times and it works for me without any problems. You can check whether you have the latest version and whether there are perhaps problems with another plugin.

schroding3r commented 3 months ago

How strange...would you be able to share the config file you used? Maybe I've set up targeting incorrectly or something... I am running my instances in a docker container using this project: https://docker-minecraft-server.readthedocs.io/en/latest/ but I would be extremely surprised if that mattered in this case.

HttpRafa commented 3 months ago

I just Ctl+C and Ctl+V the config you posted.

HttpRafa commented 3 months ago

What Minecraft version are you using?

How strange...would you be able to share the config file you used? Maybe I've set up targeting incorrectly or something... I am running my instances in a docker container using this project: https://docker-minecraft-server.readthedocs.io/en/latest/ but I would be extremely surprised if that mattered in this case.

schroding3r commented 3 months ago

Spigot 1.21 I checked the logs and it says that it loaded the config in 0 cycles, is that accurate or is it failing to load our config file?

[17:00:47 INFO]: [CreeperRecover] Loading CreeperRecover v1.0.12
[17:00:47 INFO]: ➜ CreeperRecover ● Loading CreeperRecover version 1.0.12
[17:00:48 INFO]: ➜ CreeperRecover ● The config loaded in 0 cycles.
(...)
[17:01:03 INFO]: [CreeperRecover] Enabling CreeperRecover v1.0.12
(...)
[17:01:03 INFO]: ➜ CreeperRecover ● The CreeperRecover plugin is up to date.
HttpRafa commented 3 months ago

0 cycles is normal

schroding3r commented 3 months ago

Yeah even with a newly compiled Spigot 1.21 jar, outside of docker, the plugin loads fine, the command to repair works, but it won't do it automatically. Is there any place I should look for potential conflicts or anything? I've removed all other mods and everything, it's pretty much a fresh server.

You said it worked for you several times, was that on a Spigot server? Sorry to keep bugging you, I appreciate your help and your plugin

HttpRafa commented 3 months ago

Can you replace Spigot with Paper. Maybe it is an issue with that.