search

Hu-Fi / Mr.Market

Mr. Market is the exchange oracle of HuFi, and a CeFi crypto bot on Mixin Messenger
https://mr-market-one.vercel.app
GNU Affero General Public License v3.0
1 stars 6 forks source link

feature/75-order-details #135

Closed mj-blockydevs closed 2 months ago

vercel[bot] commented 3 months ago

@arianejasuwienas is attempting to deploy a commit to the hufi Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mr-market ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 10:00am
zed-wong commented 2 months ago

For order details page, I think we will need to handle not found situation.

spot/history/[id]/+page.ts will get the order details from api. it's possible the order doesn't exist. we will need to show order not found.

mj-blockydevs commented 2 months ago

OK, I've added the fee added to the calculations.

zed-wong commented 2 months ago

@mj-blockydevs a few changes to make:

  1. let's remove the fee above balance, and keep the bottom aligned
  2. keep the market price as text, don't set it to current price
  3. also remove the fee field inside the confirm dialog
  4. the estimated price seems wrong

image image

zed-wong commented 2 months ago

Sorry that was a misunderstand. I was meant to add the fee to calculate the payment amount, not to show the fee in ui.

arianejasuwienas commented 2 months ago

@zed-wong Mixin receives the amount with the fee included. But since users are typing the payment amount in the input, we have to add this fee later / display it somewhere else than the same input.

zed-wong commented 2 months ago

@zed-wong Mixin receives the amount with the fee included. But since users are typing the payment amount in the input, we have to add this fee later / display it somewhere else than the same input.

It will be inside the order details page, just as exchanges they don't show fees when place order

arianejasuwienas commented 2 months ago

OK, so I've removed fee details displayed in earlier stages of creating an order.

zed-wong commented 2 months ago

@mj-blockydevs a few changes to make:

1. let's remove the `fee` above balance, and keep the bottom aligned

2. keep the `market price` as text, don't set it to current price

3. also remove the fee field inside the confirm dialog

4. the estimated price seems wrong

image image

Except what we need to get done above, we also need to being able to palce order without login. Which means the balance validation only happens when user connected wallet.

arianejasuwienas commented 2 months ago

@zed-wong sorry for the delay, I was sure I removed the Draft flag earlier. You can take a look at this PR now.

zed-wong commented 2 months ago

I've merged this branch into https://github.com/Hu-Fi/Mr.Market/tree/spot and started edit based on it, we still got a lot details to considerate, I will close this pr and handle them