search

Hu-Fi / Mr.Market

Mr. Market is the exchange oracle of HuFi, and a CeFi crypto bot on Mixin Messenger
https://mr-market-one.vercel.app
GNU Affero General Public License v3.0
1 stars 6 forks source link

update bot id #153

Closed zed-wong closed 2 months ago

zed-wong commented 2 months ago

Type

enhancement

Description

Changes walkthrough

Relevant files
Enhancement
constants.ts
Update Default BOT_ID in Constants                                             
interface/src/lib/helpers/constants.ts - Updated the default BOT_ID to a new value.
+1/-1     

✨ PR-Agent usage: Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
mr-market ✅ Ready (Inspect) Visit Preview Apr 15, 2024 1:00pm
railway-app[bot] commented 2 months ago

This PR is being deployed to Railway 🚅

railway-app[bot] commented 2 months ago

This PR is being deployed to Railway 🚅

Mr.Market: ◻️ REMOVED

github-actions[bot] commented 2 months ago

PR Description updated to latest commit (https://github.com/Hu-Fi/Mr.Market/commit/9ffda9471d4b783f02b4f0bdcff932600c24bd33)

github-actions[bot] commented 2 months ago

PR Review

(Review updated until commit https://github.com/Hu-Fi/Mr.Market/commit/9ffda9471d4b783f02b4f0bdcff932600c24bd33)

⏱️ Estimated effort to review [1-5] 1, because the PR involves a simple change of updating a constant value in a single file, which is straightforward and requires minimal review effort.
🧪 Relevant tests No
🔍 Possible issues No
🔒 Security concerns No
Code feedback:
✨ Review tool usage guide:
**Overview:** The `review` tool scans the PR code changes, and generates a PR review which includes several types of feedbacks, such as possible PR issues, security threats and relevant test in the PR. More feedbacks can be [added](https://pr-agent-docs.codium.ai/tools/review/#general-configurations) by configuring the tool. The tool can be triggered [automatically](https://pr-agent-docs.codium.ai/usage-guide/automations_and_usage/#github-app-automatic-tools-when-a-new-pr-is-opened) every time a new PR is opened, or can be invoked manually by commenting on any PR. - When commenting, to edit [configurations](https://github.com/Codium-ai/pr-agent/blob/main/pr_agent/settings/configuration.toml#L23) related to the review tool (`pr_reviewer` section), use the following template: ``` /review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=... ``` - With a [configuration file](https://pr-agent-docs.codium.ai/usage-guide/configuration_options/), use the following template: ``` [pr_reviewer] some_config1=... some_config2=... ``` See the review [usage page](https://pr-agent-docs.codium.ai/tools/review/) for a comprehensive guide on using this tool.
github-actions[bot] commented 2 months ago

PR Code Suggestions

CategorySuggestions                                                                                                                                                       
Best practice
Improve the robustness of the environment variable check. ___ **Consider using a more robust falsy check for env.PUBLIC_BOT_ID to ensure that the fallback
value is used only when env.PUBLIC_BOT_ID is undefined. Using a strict equality check
against undefined can prevent unintended fallbacks when env.PUBLIC_BOT_ID is an empty
string or null.** [interface/src/lib/helpers/constants.ts [8]](https://github.com/Hu-Fi/Mr.Market/pull/153/files#diff-1d9500711f0f58654b9e0e95aa0e7fdc798a0b74f1c2310b09e52123e52d6bf2R8-R8) ```diff -export const BOT_ID = env.PUBLIC_BOT_ID || '73179ddc-3e29-485b-bb13-03f514d4318e' +export const BOT_ID = env.PUBLIC_BOT_ID !== undefined ? env.PUBLIC_BOT_ID : '73179ddc-3e29-485b-bb13-03f514d4318e' ```
✨ Improve tool usage guide:
**Overview:** The `improve` tool scans the PR code changes, and automatically generates suggestions for improving the PR code. The tool can be triggered [automatically](https://pr-agent-docs.codium.ai/usage-guide/automations_and_usage/#github-app-automatic-tools-when-a-new-pr-is-opened) every time a new PR is opened, or can be invoked manually by commenting on a PR. - When commenting, to edit [configurations](https://github.com/Codium-ai/pr-agent/blob/main/pr_agent/settings/configuration.toml#L78) related to the improve tool (`pr_code_suggestions` section), use the following template: ``` /improve --pr_code_suggestions.some_config1=... --pr_code_suggestions.some_config2=... ``` - With a [configuration file](https://pr-agent-docs.codium.ai/usage-guide/configuration_options/), use the following template: ``` [pr_code_suggestions] some_config1=... some_config2=... ``` See the improve [usage page](https://pr-agent-docs.codium.ai/tools/improve/) for a comprehensive guide on using this tool.
github-actions[bot] commented 2 months ago

PR Description updated to latest commit (https://github.com/Hu-Fi/Mr.Market/commit/9ffda9471d4b783f02b4f0bdcff932600c24bd33)

github-actions[bot] commented 2 months ago

Persistent review updated to latest commit https://github.com/Hu-Fi/Mr.Market/commit/9ffda9471d4b783f02b4f0bdcff932600c24bd33

github-actions[bot] commented 2 months ago

PR Code Suggestions

CategorySuggestions                                                                                                                                                       
Enhancement
Improve the robustness of the fallback mechanism for env.PUBLIC_BOT_ID. ___ **Consider using a more robust falsy check for env.PUBLIC_BOT_ID to ensure that the fallback
value is used only when env.PUBLIC_BOT_ID is undefined. Using a strict equality check
against undefined can prevent unintended fallbacks when env.PUBLIC_BOT_ID might be an
empty string or null, which are technically valid falsy values but might not be intended
as triggers for fallback.** [interface/src/lib/helpers/constants.ts [8]](https://github.com/Hu-Fi/Mr.Market/pull/153/files#diff-1d9500711f0f58654b9e0e95aa0e7fdc798a0b74f1c2310b09e52123e52d6bf2R8-R8) ```diff -export const BOT_ID = env.PUBLIC_BOT_ID || '73179ddc-3e29-485b-bb13-03f514d4318e' +export const BOT_ID = env.PUBLIC_BOT_ID !== undefined ? env.PUBLIC_BOT_ID : '73179ddc-3e29-485b-bb13-03f514d4318e' ```
✨ Improve tool usage guide:
**Overview:** The `improve` tool scans the PR code changes, and automatically generates suggestions for improving the PR code. The tool can be triggered [automatically](https://pr-agent-docs.codium.ai/usage-guide/automations_and_usage/#github-app-automatic-tools-when-a-new-pr-is-opened) every time a new PR is opened, or can be invoked manually by commenting on a PR. - When commenting, to edit [configurations](https://github.com/Codium-ai/pr-agent/blob/main/pr_agent/settings/configuration.toml#L78) related to the improve tool (`pr_code_suggestions` section), use the following template: ``` /improve --pr_code_suggestions.some_config1=... --pr_code_suggestions.some_config2=... ``` - With a [configuration file](https://pr-agent-docs.codium.ai/usage-guide/configuration_options/), use the following template: ``` [pr_code_suggestions] some_config1=... some_config2=... ``` See the improve [usage page](https://pr-agent-docs.codium.ai/tools/improve/) for a comprehensive guide on using this tool.