Hu-Fi / Mr.Market

Mr. Market is the exchange oracle of HuFi, and a CeFi crypto bot on Mixin Messenger
https://mr-market-one.vercel.app
GNU Affero General Public License v3.0
1 stars 6 forks source link

cleanup backend #48

Closed posix4e closed 4 months ago

posix4e commented 4 months ago

Type

enhancement


Description


Changes walkthrough

Relevant files
Configuration changes
vercel.json
Removal of Vercel Configuration                                                   

server/vercel.json - Removed the Vercel configuration file.
+0/-15   

PR-Agent usage: Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mr-market ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 9, 2024 3:52pm
mr-market-back ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 9, 2024 3:52pm
github-actions[bot] commented 4 months ago

PR Description updated to latest commit (https://github.com/Hu-Fi/Mr.Market/commit/11e4ac76f2cf4644cbbc0e9234a15b20a72c1e29)

github-actions[bot] commented 4 months ago

PR Review

(Review updated until commit https://github.com/Hu-Fi/Mr.Market/commit/11e4ac76f2cf4644cbbc0e9234a15b20a72c1e29)

⏱️ Estimated effort to review [1-5] 1, because the PR involves a simple removal of a configuration file without adding or modifying any code. The review focuses on understanding the implications of removing the `vercel.json` file and ensuring that the removal aligns with the project's deployment and operational strategies.
🧪 Relevant tests No
🔍 Possible issues Deployment Configuration: Removing `vercel.json` may affect the deployment process if the project is still hosted on Vercel. Ensure that the deployment strategy has been updated to reflect this change.
🔒 Security concerns No
Code feedback:

✨ Review tool usage guide:
**Overview:** The `review` tool scans the PR code changes, and generates a PR review. The tool can be triggered [automatically](https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#github-app-automatic-tools) every time a new PR is opened, or can be invoked manually by commenting on any PR. When commenting, to edit [configurations](https://github.com/Codium-ai/pr-agent/blob/main/pr_agent/settings/configuration.toml#L19) related to the review tool (`pr_reviewer` section), use the following template: ``` /review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=... ``` With a [configuration file](https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#working-with-github-app), use the following template: ``` [pr_reviewer] some_config1=... some_config2=... ```
Utilizing extra instructions
The `review` tool can be configured with extra instructions, which can be used to guide the model to a feedback tailored to the needs of your project. Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify the relevant sub-tool, and the relevant aspects of the PR that you want to emphasize. Examples for extra instructions: ``` [pr_reviewer] # /review # extra_instructions=""" In the 'possible issues' section, emphasize the following: - Does the code logic cover relevant edge cases? - Is the code logic clear and easy to understand? - Is the code logic efficient? ... """ ``` Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.
How to enable\disable automation
- When you first install PR-Agent app, the [default mode](https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#github-app-automatic-tools) for the `review` tool is: ``` pr_commands = ["/review", ...] ``` meaning the `review` tool will run automatically on every PR, with the default configuration. Edit this field to enable/disable the tool, or to change the used configurations
Auto-labels
The `review` tool can auto-generate two specific types of labels for a PR: - a `possible security issue` label, that detects possible [security issues](https://github.com/Codium-ai/pr-agent/blob/tr/user_description/pr_agent/settings/pr_reviewer_prompts.toml#L136) (`enable_review_labels_security` flag) - a `Review effort [1-5]: x` label, where x is the estimated effort to review the PR (`enable_review_labels_effort` flag)
Extra sub-tools
The `review` tool provides a collection of possible feedbacks about a PR. It is recommended to review the [possible options](https://github.com/Codium-ai/pr-agent/blob/main/docs/REVIEW.md#enabledisable-features), and choose the ones relevant for your use case. Some of the feature that are disabled by default are quite useful, and should be considered for enabling. For example: `require_score_review`, `require_soc2_ticket`, and more.
Auto-approve PRs
By invoking: ``` /review auto_approve ``` The tool will automatically approve the PR, and add a comment with the approval. To ensure safety, the auto-approval feature is disabled by default. To enable auto-approval, you need to actively set in a pre-defined configuration file the following: ``` [pr_reviewer] enable_auto_approval = true ``` (this specific flag cannot be set with a command line argument, only in the configuration file, committed to the repository) You can also enable auto-approval only if the PR meets certain requirements, such as that the `estimated_review_effort` is equal or below a certain threshold, by adjusting the flag: ``` [pr_reviewer] maximal_review_effort = 5 ```
More PR-Agent commands
> To invoke the PR-Agent, add a comment using one of the following commands: > - **/review**: Request a review of your Pull Request. > - **/describe**: Update the PR title and description based on the contents of the PR. > - **/improve [--extended]**: Suggest code improvements. Extended mode provides a higher quality feedback. > - **/ask \**: Ask a question about the PR. > - **/update_changelog**: Update the changelog based on the PR's contents. > - **/add_docs** 💎: Generate docstring for new components introduced in the PR. > - **/generate_labels** 💎: Generate labels for the PR based on the PR's contents. > - **/analyze** 💎: Automatically analyzes the PR, and presents changes walkthrough for each component. >See the [tools guide](https://github.com/Codium-ai/pr-agent/blob/main/docs/TOOLS_GUIDE.md) for more details. >To list the possible configuration parameters, add a **/config** comment.
See the [review usage](https://github.com/Codium-ai/pr-agent/blob/main/docs/REVIEW.md) page for a comprehensive guide on using this tool.
github-actions[bot] commented 4 months ago

PR Code Suggestions

No code suggestions found for PR.

github-actions[bot] commented 4 months ago

PR Description updated to latest commit (https://github.com/Hu-Fi/Mr.Market/commit/11e4ac76f2cf4644cbbc0e9234a15b20a72c1e29)

github-actions[bot] commented 4 months ago

Persistent review updated to latest commit https://github.com/Hu-Fi/Mr.Market/commit/11e4ac76f2cf4644cbbc0e9234a15b20a72c1e29

github-actions[bot] commented 4 months ago

PR Code Suggestions

No code suggestions found for PR.