search

Hu-Fi / Mr.Market

Mr. Market is the exchange oracle of HuFi, and a CeFi crypto bot on Mixin Messenger
https://mr-market-one.vercel.app
GNU Affero General Public License v3.0
1 stars 6 forks source link

Try to fix railway #58

Closed posix4e closed 4 months ago

posix4e commented 4 months ago

User description

remove yarn lock allow dependency updates

Type

enhancement

Description

Changes walkthrough

Relevant files
Enhancement
package.json
Update NestJS dependencies and remove unused axios dependency
server/package.json
  • Updated @nestjs/common, @nestjs/platform-express,
    @nestjs/platform-socket.io, and @nestjs/websockets to their latest
    versions.
  • Updated development dependencies including @nestjs/cli,
    @nestjs/schematics, @nestjs/testing, @types/jest, @types/node,
    @types/zxcvbn, jest, ts-jest, and tsconfig-paths to their latest
    versions.
  • Removed @nestjs/axios dependency.
    		• +13/-14 

    ✨ PR-Agent usage: Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    vercel[bot] commented 4 months ago

    The latest updates on your projects. Learn more about Vercel for Git ↗︎

    Name Status Preview Updated (UTC)
    mr-market ✅ Ready (Inspect) Visit Preview Mar 12, 2024 0:10am
    railway-app[bot] commented 4 months ago

    This PR is being deployed to Railway 🚅

    Mr.Market: ◻️ REMOVED

    github-actions[bot] commented 4 months ago

    PR Description updated to latest commit (https://github.com/Hu-Fi/Mr.Market/commit/51ff039f5f440a3dbb5c4c13dd69d1edd00f8fff)

    github-actions[bot] commented 4 months ago

    PR Review

    (Review updated until commit https://github.com/Hu-Fi/Mr.Market/commit/51ff039f5f440a3dbb5c4c13dd69d1edd00f8fff)

    ⏱️ Estimated effort to review [1-5] 2, because the changes are mostly version updates in a single file, which are straightforward to review. However, ensuring compatibility and no breaking changes from the updates requires some effort.
    🧪 Relevant tests No
    🔍 Possible issues Dependency Version Mismatch: The updates to the NestJS core and platform dependencies are to specific newer versions, but ensuring that these updates do not introduce breaking changes or compatibility issues with other dependencies requires careful testing.
    Unpinned Versions: Some dependencies have been updated to use carets (^), which allows for minor updates. This can lead to unintentional updates that might introduce breaking changes or inconsistencies in the future.
    🔒 Security concerns No
    Code feedback:
    relevant fileserver/package.json
    suggestion       Consider pinning the dependency versions to avoid automatic updates that could introduce breaking changes or inconsistencies. While using carets (^) allows for easier updates, it also increases the risk of automatically updating to a version with breaking changes. [important]
    relevant line"@nestjs/common": "10.3.3",
    relevant fileserver/package.json
    suggestion       Ensure that all updated dependencies are tested thoroughly, especially for major version updates, to prevent runtime errors or breaking changes. This might involve updating unit tests or adding new ones to cover the changes. [important]
    relevant line"@nestjs/cli": "^10.3.2",
    relevant fileserver/package.json
    suggestion       Review the removal of `@nestjs/axios` to ensure that no part of the application relies on it. Removing a dependency should be accompanied by a thorough search for its usage across the project. [medium]
    relevant line- "@nestjs/axios": "^2.0.0",
    ✨ Review tool usage guide:
    **Overview:** The `review` tool scans the PR code changes, and generates a PR review. The tool can be triggered [automatically](https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#github-app-automatic-tools) every time a new PR is opened, or can be invoked manually by commenting on any PR. When commenting, to edit [configurations](https://github.com/Codium-ai/pr-agent/blob/main/pr_agent/settings/configuration.toml#L19) related to the review tool (`pr_reviewer` section), use the following template: ``` /review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=... ``` With a [configuration file](https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#working-with-github-app), use the following template: ``` [pr_reviewer] some_config1=... some_config2=... ```
    Utilizing extra instructions
    The `review` tool can be configured with extra instructions, which can be used to guide the model to a feedback tailored to the needs of your project. Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify the relevant sub-tool, and the relevant aspects of the PR that you want to emphasize. Examples for extra instructions: ``` [pr_reviewer] # /review # extra_instructions=""" In the 'possible issues' section, emphasize the following: - Does the code logic cover relevant edge cases? - Is the code logic clear and easy to understand? - Is the code logic efficient? ... """ ``` Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.
    How to enable\disable automation
    - When you first install PR-Agent app, the [default mode](https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#github-app-automatic-tools) for the `review` tool is: ``` pr_commands = ["/review", ...] ``` meaning the `review` tool will run automatically on every PR, with the default configuration. Edit this field to enable/disable the tool, or to change the used configurations
    Auto-labels
    The `review` tool can auto-generate two specific types of labels for a PR: - a `possible security issue` label, that detects possible [security issues](https://github.com/Codium-ai/pr-agent/blob/tr/user_description/pr_agent/settings/pr_reviewer_prompts.toml#L136) (`enable_review_labels_security` flag) - a `Review effort [1-5]: x` label, where x is the estimated effort to review the PR (`enable_review_labels_effort` flag)
    Extra sub-tools
    The `review` tool provides a collection of possible feedbacks about a PR. It is recommended to review the [possible options](https://github.com/Codium-ai/pr-agent/blob/main/docs/REVIEW.md#enabledisable-features), and choose the ones relevant for your use case. Some of the feature that are disabled by default are quite useful, and should be considered for enabling. For example: `require_score_review`, `require_soc2_ticket`, and more.
    Auto-approve PRs
    By invoking: ``` /review auto_approve ``` The tool will automatically approve the PR, and add a comment with the approval. To ensure safety, the auto-approval feature is disabled by default. To enable auto-approval, you need to actively set in a pre-defined configuration file the following: ``` [pr_reviewer] enable_auto_approval = true ``` (this specific flag cannot be set with a command line argument, only in the configuration file, committed to the repository) You can also enable auto-approval only if the PR meets certain requirements, such as that the `estimated_review_effort` is equal or below a certain threshold, by adjusting the flag: ``` [pr_reviewer] maximal_review_effort = 5 ```
    More PR-Agent commands
    > To invoke the PR-Agent, add a comment using one of the following commands: > - **/review**: Request a review of your Pull Request. > - **/describe**: Update the PR title and description based on the contents of the PR. > - **/improve [--extended]**: Suggest code improvements. Extended mode provides a higher quality feedback. > - **/ask \**: Ask a question about the PR. > - **/update_changelog**: Update the changelog based on the PR's contents. > - **/add_docs** 💎: Generate docstring for new components introduced in the PR. > - **/generate_labels** 💎: Generate labels for the PR based on the PR's contents. > - **/analyze** 💎: Automatically analyzes the PR, and presents changes walkthrough for each component. >See the [tools guide](https://github.com/Codium-ai/pr-agent/blob/main/docs/TOOLS_GUIDE.md) for more details. >To list the possible configuration parameters, add a **/config** comment.
    See the [review usage](https://github.com/Codium-ai/pr-agent/blob/main/docs/REVIEW.md) page for a comprehensive guide on using this tool.
    github-actions[bot] commented 4 months ago

    PR Code Suggestions

    CategorySuggestions                                                                                                                                                       
    Best practice
    Use caret version specifier for "@nestjs/common" to allow minor updates. ___ **Consider using a caret (^) version specifier for "@nestjs/common" to allow minor version
    updates. This can help ensure that you receive bug fixes and performance improvements.** [server/package.json [24]](https://github.com/Hu-Fi/Mr.Market/pull/58/files#diff-da00458cdaeaea2314cb0e0101c85130593048072ada62de01727958c5d6ca37R24-R24) ```diff -"@nestjs/common": "10.3.3", +"@nestjs/common": "^10.3.3", ```
    ✨ Improve tool usage guide:
    **Overview:** The `improve` tool scans the PR code changes, and automatically generates suggestions for improving the PR code. The tool can be triggered [automatically](https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#github-app-automatic-tools) every time a new PR is opened, or can be invoked manually by commenting on a PR. When commenting, to edit [configurations](https://github.com/Codium-ai/pr-agent/blob/main/pr_agent/settings/configuration.toml#L69) related to the improve tool (`pr_code_suggestions` section), use the following template: ``` /improve --pr_code_suggestions.some_config1=... --pr_code_suggestions.some_config2=... ``` With a [configuration file](https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#working-with-github-app), use the following template: ``` [pr_code_suggestions] some_config1=... some_config2=... ```
    Enabling\disabling automation
    When you first install the app, the [default mode](https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#github-app-automatic-tools) for the improve tool is: ``` pr_commands = ["/improve --pr_code_suggestions.summarize=true", ...] ``` meaning the `improve` tool will run automatically on every PR, with summarization enabled. Delete this line to disable the tool from running automatically.
    Utilizing extra instructions
    Extra instructions are very important for the `improve` tool, since they enable to guide the model to suggestions that are more relevant to the specific needs of the project. Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify relevant aspects that you want the model to focus on. Examples for extra instructions: ``` [pr_code_suggestions] # /improve # extra_instructions=""" Emphasize the following aspects: - Does the code logic cover relevant edge cases? - Is the code logic clear and easy to understand? - Is the code logic efficient? ... """ ``` Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.
    A note on code suggestions quality
    - While the current AI for code is getting better and better (GPT-4), it's not flawless. Not all the suggestions will be perfect, and a user should not accept all of them automatically. - Suggestions are not meant to be simplistic. Instead, they aim to give deep feedback and raise questions, ideas and thoughts to the user, who can then use his judgment, experience, and understanding of the code base. - Recommended to use the 'extra_instructions' field to guide the model to suggestions that are more relevant to the specific needs of the project, or use the [custom suggestions :gem:](https://github.com/Codium-ai/pr-agent/blob/main/docs/CUSTOM_SUGGESTIONS.md) tool - With large PRs, best quality will be obtained by using 'improve --extended' mode.
    More PR-Agent commands
    > To invoke the PR-Agent, add a comment using one of the following commands: > - **/review**: Request a review of your Pull Request. > - **/describe**: Update the PR title and description based on the contents of the PR. > - **/improve [--extended]**: Suggest code improvements. Extended mode provides a higher quality feedback. > - **/ask \**: Ask a question about the PR. > - **/update_changelog**: Update the changelog based on the PR's contents. > - **/add_docs** 💎: Generate docstring for new components introduced in the PR. > - **/generate_labels** 💎: Generate labels for the PR based on the PR's contents. > - **/analyze** 💎: Automatically analyzes the PR, and presents changes walkthrough for each component. >See the [tools guide](https://github.com/Codium-ai/pr-agent/blob/main/docs/TOOLS_GUIDE.md) for more details. >To list the possible configuration parameters, add a **/config** comment.
    See the [improve usage](https://github.com/Codium-ai/pr-agent/blob/main/docs/IMPROVE.md) page for a more comprehensive guide on using this tool.
    github-actions[bot] commented 4 months ago

    PR Description updated to latest commit (https://github.com/Hu-Fi/Mr.Market/commit/51ff039f5f440a3dbb5c4c13dd69d1edd00f8fff)

    github-actions[bot] commented 4 months ago

    Persistent review updated to latest commit https://github.com/Hu-Fi/Mr.Market/commit/51ff039f5f440a3dbb5c4c13dd69d1edd00f8fff

    github-actions[bot] commented 4 months ago

    PR Code Suggestions

    CategorySuggestions                                                                                                                                                       
    Best practice
    Use the caret version specifier for "@nestjs/common" to automatically update to new minor versions. ___ **Consider using the caret (^) version specifier for "@nestjs/common" to ensure
    compatibility with minor updates and patches. This can help in keeping your dependencies
    up-to-date with the latest non-breaking changes.** [server/package.json [24]](https://github.com/Hu-Fi/Mr.Market/pull/58/files#diff-da00458cdaeaea2314cb0e0101c85130593048072ada62de01727958c5d6ca37R24-R24) ```diff -"@nestjs/common": "10.3.3", +"@nestjs/common": "^10.3.3", ```
    Update all NestJS dependencies to the same version to ensure compatibility. ___ **Ensure that all your NestJS related dependencies are updated to the same version to avoid
    compatibility issues. For example, "@nestjs/core" is currently at "10.2.10", which might
    not be fully compatible with other NestJS dependencies at "10.3.3" or "^10.2.10".** [server/package.json [26]](https://github.com/Hu-Fi/Mr.Market/pull/58/files#diff-da00458cdaeaea2314cb0e0101c85130593048072ada62de01727958c5d6ca37R26-R26) ```diff -"@nestjs/core": "10.2.10", +"@nestjs/core": "^10.3.3", ```
    Use consistent version specifiers for all "@types" dependencies. ___ **Consider using the same version specifier for all "@types" dependencies to ensure
    consistency and predictability in your type definitions. For instance, "@types/jest" and
    "@types/node" are using "^", while others are not.** [server/package.json [67-70]](https://github.com/Hu-Fi/Mr.Market/pull/58/files#diff-da00458cdaeaea2314cb0e0101c85130593048072ada62de01727958c5d6ca37R67-R70) ```diff "@types/jest": "^29.5.1", "@types/node": "^18.16.12", +"@types/bcrypt": "^5.0.2", +"@types/supertest": "^2.0.15", +"@types/zxcvbn": "^4.4.1", ```
    Keep "typescript", "ts-jest", and "ts-node" versions in sync to avoid incompatibilities. ___ **It's a good practice to keep the version of "typescript" in sync with the version of
    "ts-jest" and "ts-node" to avoid potential incompatibilities due to differences in
    TypeScript features or bug fixes.** [server/package.json [84]](https://github.com/Hu-Fi/Mr.Market/pull/58/files#diff-da00458cdaeaea2314cb0e0101c85130593048072ada62de01727958c5d6ca37R84-R84) ```diff -"typescript": "^5.0.0" +"typescript": "^5.0.0", +"ts-jest": "^29.1.1", +"ts-node": "^10.0.0", ```
    Enhancement
    Update all dependencies to their latest versions for better security and maintainability. ___ **For better maintainability and to avoid potential security vulnerabilities, consider
    updating all your dependencies to their latest versions. This includes both direct
    dependencies and devDependencies.** [server/package.json [24-29]](https://github.com/Hu-Fi/Mr.Market/pull/58/files#diff-da00458cdaeaea2314cb0e0101c85130593048072ada62de01727958c5d6ca37R24-R29) ```diff -"@nestjs/common": "10.3.3", -"@nestjs/core": "10.2.10", -"@nestjs/jwt": "^10.0.3", -"@nestjs/passport": "^10.0.0", -"@nestjs/platform-express": "^10.2.10", +"@nestjs/common": "^10.3.3", +"@nestjs/core": "^10.3.3", +"@nestjs/jwt": "^10.3.3", +"@nestjs/passport": "^10.3.3", +"@nestjs/platform-express": "^10.3.3", ```
    ✨ Improve tool usage guide:
    **Overview:** The `improve` tool scans the PR code changes, and automatically generates suggestions for improving the PR code. The tool can be triggered [automatically](https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#github-app-automatic-tools) every time a new PR is opened, or can be invoked manually by commenting on a PR. When commenting, to edit [configurations](https://github.com/Codium-ai/pr-agent/blob/main/pr_agent/settings/configuration.toml#L69) related to the improve tool (`pr_code_suggestions` section), use the following template: ``` /improve --pr_code_suggestions.some_config1=... --pr_code_suggestions.some_config2=... ``` With a [configuration file](https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#working-with-github-app), use the following template: ``` [pr_code_suggestions] some_config1=... some_config2=... ```
    Enabling\disabling automation
    When you first install the app, the [default mode](https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#github-app-automatic-tools) for the improve tool is: ``` pr_commands = ["/improve --pr_code_suggestions.summarize=true", ...] ``` meaning the `improve` tool will run automatically on every PR, with summarization enabled. Delete this line to disable the tool from running automatically.
    Utilizing extra instructions
    Extra instructions are very important for the `improve` tool, since they enable to guide the model to suggestions that are more relevant to the specific needs of the project. Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify relevant aspects that you want the model to focus on. Examples for extra instructions: ``` [pr_code_suggestions] # /improve # extra_instructions=""" Emphasize the following aspects: - Does the code logic cover relevant edge cases? - Is the code logic clear and easy to understand? - Is the code logic efficient? ... """ ``` Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.
    A note on code suggestions quality
    - While the current AI for code is getting better and better (GPT-4), it's not flawless. Not all the suggestions will be perfect, and a user should not accept all of them automatically. - Suggestions are not meant to be simplistic. Instead, they aim to give deep feedback and raise questions, ideas and thoughts to the user, who can then use his judgment, experience, and understanding of the code base. - Recommended to use the 'extra_instructions' field to guide the model to suggestions that are more relevant to the specific needs of the project, or use the [custom suggestions :gem:](https://github.com/Codium-ai/pr-agent/blob/main/docs/CUSTOM_SUGGESTIONS.md) tool - With large PRs, best quality will be obtained by using 'improve --extended' mode.
    More PR-Agent commands
    > To invoke the PR-Agent, add a comment using one of the following commands: > - **/review**: Request a review of your Pull Request. > - **/describe**: Update the PR title and description based on the contents of the PR. > - **/improve [--extended]**: Suggest code improvements. Extended mode provides a higher quality feedback. > - **/ask \**: Ask a question about the PR. > - **/update_changelog**: Update the changelog based on the PR's contents. > - **/add_docs** 💎: Generate docstring for new components introduced in the PR. > - **/generate_labels** 💎: Generate labels for the PR based on the PR's contents. > - **/analyze** 💎: Automatically analyzes the PR, and presents changes walkthrough for each component. >See the [tools guide](https://github.com/Codium-ai/pr-agent/blob/main/docs/TOOLS_GUIDE.md) for more details. >To list the possible configuration parameters, add a **/config** comment.
    See the [improve usage](https://github.com/Codium-ai/pr-agent/blob/main/docs/IMPROVE.md) page for a more comprehensive guide on using this tool.