Open jordanbtucker opened 1 week ago
This PR ungroups Set-Cookie headers since each header should appear independently. According to MDN:
Set-Cookie
To send multiple cookies, multiple Set-Cookie headers should be sent in the same response.
For example, the following is correct:
Set-Cookie: a=b Set-Cookie: c=d
While the following is incorrect:
Set-Cookie: a=b,c=d
This PR achieves this by:
formatHeaders
utils/misc.ts
set-cookie
private formatHeaders
HttpResponseTextDocumentView
private static formatHeaders
HttpResponseWebview
getFullResponseString
createRequestInTempFile
HistoryController
Fixes #722
This PR ungroups
Set-Cookie
headers since each header should appear independently. According to MDN:For example, the following is correct:
While the following is incorrect:
This PR achieves this by:
formatHeaders
function inutils/misc.ts
that treatsset-cookie
as a special case.private formatHeaders
function fromHttpResponseTextDocumentView
and updating all calls to use the new utilityformatHeaders
function.private static formatHeaders
function fromHttpResponseWebview
and updating all calls to use the new utilityformatHeaders
function.getFullResponseString
inHttpResponseWebview
to use the new utilityformatHeaders
function.createRequestInTempFile
inHistoryController
to use the new utilityformatHeaders
function.Fixes #722