Hual / samp-discord-plugin

SA:MP Discord Rich Presence plugin
GNU General Public License v3.0
69 stars 35 forks source link

Process deadlock on /q #14

Closed VictorFerraresi closed 6 years ago

VictorFerraresi commented 6 years ago

Seems like the plugin is generating some kind of DeadLock in the Discord::Shutdown() call @ the unhook, that makes the GTA SA freeze when you /q. You're forced to quit the game via CTRL+ALT+DEL.

Hual commented 6 years ago

Is there any specific way to reproduce it?

VictorFerraresi commented 6 years ago

I don't know if I've done something wrong, but simply by loading it via modloader I can't /q at all. My screen freezes, the SAMP mouse keeps moving if I want, and I have to CTRL ALT DEL to delete the gta_sa.exe. 100% of the times, no specific thing to be done to reproduce. It doesn't happens only for me.

Hual commented 6 years ago

I haven't tested using modloader, just a generic ASI loader.

VictorFerraresi commented 6 years ago

I've just tried it with the Silent ASI's loader, dropping the .asi on the root folder of the GTA_SA.exe. Same behaviour

Hual commented 6 years ago

And you can reproduce it every time? If so, what OS are you running?

VictorFerraresi commented 6 years ago

100% of the times. Windows 7 64b 7601 compilation with SP1. Seems like someone else already faced this problem and posted it on the last page of your SAMP Forum's topic of this tool.

VictorFerraresi commented 6 years ago

Seems like my W10 users(players) are not facing this issue, only the W7 ones.

Hual commented 6 years ago

Can you try the new build?

VictorFerraresi commented 6 years ago

Still the same behaviour. 100% of my server's W10 users have no issue with the /q at all.

VictorFerraresi commented 6 years ago

https://blogs.msdn.microsoft.com/oldnewthing/20040127-00/?p=40873/ I'm risking to say it's something about this

Hual commented 6 years ago

It seems to be an issue with discord-rpc: https://github.com/discordapp/discord-rpc/issues/134

Hual commented 6 years ago

Resolved in 85bb34beb6961dc325c7f78e89d7f9596f6b1624.