HuangJunJie2017 / UDP-Pose

Official code of The Devil is in the Details: Delving into Unbiased Data Processing for Human Pose Estimation
Apache License 2.0
307 stars 54 forks source link

Question about the pre-process #26

Closed AndersonZhangyq closed 3 years ago

AndersonZhangyq commented 3 years ago

In _xywh2cs(self, x, y, w, h), to get the scale, the bounding box is rescaled to match the aspect ratio of the model input.

From the source code, I think the standard workflow is to rescale the bounding box and then crop the image according to the rescaled bounding box, which is inconsistent with the standard workflow mentioned in paper(which is to rescale the cropped image). And I found this behavior in mmpose, which seems to be a common behavior.

Is there any special reason to do so? In my point of view, this behavior may includes much more context then expected. Or the input aspect ratio chosen is designed for COCO, based on the statistics of aspect ratio of person bounding boxes?

HuangJunJie2017 commented 3 years ago

this function is inherited from the orginal hrnet without modification for fair comparison~

AndersonZhangyq commented 3 years ago

Fair enough