Open danielcrane opened 2 years ago
Sorry for just replying you now.
My implementation is based on an earlier version of the paper int ARXIV. In this version, the equation (6) was
and the pseudocode was
By the way,the line 12 in the pseudocode is Proximity * si which is not math the equation (6). Maybe in the version of officially published paper , these two points had been optimized .
Sorry for asking in English, but I have a couple of questions regarding your implementation of Confluence.
1.
May I ask where the following line comes from in the paper?
https://github.com/Huangdebo/Confluence/blob/8347895175179e1acc222826594eb576047de4b5/confluence.py#L167
In equation (6) of the paper, they weight the confidence score like so:
where
P
is the Manhattan distance, ands
is the confidence, however in your case it looks more like you're doing:I suppose the outcome will likely be the same, but I was just wondering if this method was mentioned in the paper, as I can't see it?
2.
In section 3.5 of the paper, after selecting the optimal bounding box, they then decay the confidences of all bounding boxes within close proximity (
p_thres
) of this optimal bounding box.As far as I can see, in your implementation this stage was skipped, and instead your just delete all bounding boxes within
p_thres
of the optimal bounding box:https://github.com/Huangdebo/Confluence/blob/8347895175179e1acc222826594eb576047de4b5/confluence.py#L188-L190
May I ask why you decided to do this instead? Did you run some tests and this method performed better?
Thanks so much in advance!