Huangyan9188 / gogoprotobuf

Automatically exported from code.google.com/p/gogoprotobuf
Other
0 stars 0 forks source link

Option to expose proto enum constants with proper Go style #30

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
Currently proto CONSTANTS_LIKE_THIS are being exposed as such within Go code 
instead of translating to camelCase like message names. This is causing golint 
to freak out.

An option (or change to the generated files) to generate golint-friendly code 
would be great.

Original issue reported on code.google.com by andyb...@chromium.org on 10 Nov 2014 at 6:28

GoogleCodeExporter commented 9 years ago
Sounds like a good feature, I like it :)

Since gogoprotobuf is a fork of goprotobuf, which is maintained by the go
authors, let us first make sure that they are not planning to fix this.
I think they should also care whether their code lints, but I have been
wrong before.
I just don't want to add another extension if they are planning to fix this
anyway.

Would you mind posting an issue on goprotobuf and pasting the link here, so
I can subscribe.

Original comment by awalterschulze on 11 Nov 2014 at 6:47

GoogleCodeExporter commented 9 years ago
https://code.google.com/p/goprotobuf/issues/detail?id=59

Original comment by andyb...@chromium.org on 11 Nov 2014 at 7:51

GoogleCodeExporter commented 9 years ago
Ha ha, like I said I have been wrong before :)

I think this will be a good feature to add.

Original comment by awalterschulze on 11 Nov 2014 at 8:06

GoogleCodeExporter commented 9 years ago
Sweet! Thanks for the quick follow-up. :)

Original comment by andyb...@chromium.org on 11 Nov 2014 at 8:32