HubPress / hubpress.io

A web application to build your blog on GitHub
MIT License
2.8k stars 2.62k forks source link

Load language files for highlight.js to allow better highlighting for code languages #236

Open jarcane opened 9 years ago

jarcane commented 9 years ago

I was disappointed to discover on my most recent post that syntax highlighting for Rust didn't work, and went digging in the page source and discovered that this may be because HubPress is using highlight.js 8.4, while the current version is 8.6.

I went digging around the source tree to try and find where I might update this manually, but I wasn't able to find where in the system this actually gets added to the final page.

anthonny commented 9 years ago

Hi @jarcane ! :+1: I will upgrade the version of Highlight.js in the next version of HubPress :smile:

jarcane commented 9 years ago

Hmm. After further experimentation, it seems this may not be the only issue. I might be doing something wrong. Haskell's been supported since at least 7.5, and Scheme since 8.2, but I'm not getting either one of them to highlight either.

As you can see, the raw file here: https://raw.githubusercontent.com/jarcane/jarcane.github.io/master/_posts/2014-10-03-Haskell-is-Cool.adoc

Produces syntax highlighting for neither language in the resulting output: https://jarcane.github.io/2014/10/03/Haskell-is-Cool.html

Is there something I'm doing wrong with the syntax here?

anthonny commented 9 years ago

Could you try with [source, ...] instead of [code, ...]

jarcane commented 9 years ago

Changing that does seem to apply some syntax highlighting to the Scheme blocks at least, but incompletely.

See here: https://jarcane.github.io/2014/10/03/Haskell-is-Cool.html

On Fri, Jul 10, 2015 at 3:28 PM, Anthonny Quérouil <notifications@github.com

wrote:

Could you try with [source, ...] instead of [code, ...]

— Reply to this email directly or view it on GitHub https://github.com/HubPress/hubpress.io/issues/236#issuecomment-120399147 .

anthonny commented 9 years ago

It's because i load this file only :

https://cdnjs.cloudflare.com/ajax/libs/highlight.js/8.4/highlight.min.js

I must add : https://cdnjs.cloudflare.com/ajax/libs/highlight.js/8.4/languages/haskell.min.js

and the js for each language ...