HubPress / hubpress.io

A web application to build your blog on GitHub
MIT License
2.81k stars 2.63k forks source link

CNAME addition breaks admin #244

Open ssundarraj opened 9 years ago

ssundarraj commented 9 years ago

When I add a CNAME it doesn't save, and the admin panel doesn't open.

anthonny commented 9 years ago

Hi @ssundarraj!

I can't find your fork of HubPress

ssundarraj commented 9 years ago

I deleted my fork of hubpress. This issue occurred multiple times. I can reproduce the error for you if you want me to.

anthonny commented 9 years ago

Yes if you have a moment to reproduce, i could understand what happen Thank you!

ssundarraj commented 9 years ago

http://github.com/ssundarraj/hubpress.io

anthonny commented 9 years ago

Ok i understand the problem. You use a CNAME for your repository ssundarraj.github.io => ssundarraj.me

So for your instance of HubPress, you do not have to define a CNAME because by default your instance is available at http://ssundarraj.me/hubpress.io

The problem is for the link, without the CNAME the links in HubPress are https://ssundarraj.github.io/hubpress.io I will add a property in the config to force the URL

Thank you for your help

ssundarraj commented 9 years ago

:+1:

wols commented 8 years ago

Is the fix available? Please help!

anthonny commented 8 years ago

@wols not yet sorry

wols commented 8 years ago

A messy workaround:

git pull
git mv CNAME CNAME.tmp
git commit -m "hidden CNAME"
git push

http://ssundarraj.me/ gives 404 http://ssundarraj.github.io/blog/hubpress works

git pull
git mv CNAME.tmp CNAME
git commit -m "add CNAME"
git push

http://ssundarraj.me/ works again

jaredmorgs commented 7 years ago

Appears to be a valid bug still @anthonny

I won't close this one off unless you overrule the decision.