search

HubPress / hubpress.io

A web application to build your blog on GitHub
MIT License
2.81k stars 2.62k forks source link

CSS @import should work on both HTTP and HTTPS pages #427

Closed locnh closed 7 years ago

locnh commented 8 years ago

CSS @import should work on both HTTP and HTTPS pages Themes have changes:

jaredmorgs commented 7 years ago

@anthonny This PR has aged now. Could we still accept the concepts in this PR, even if we can't accept the code changes due to refactoring?

anthonny commented 7 years ago

I agree with @jbrizio It is consider as an anti-pattern if the asset is available on SSL See https://www.paulirish.com/2010/the-protocol-relative-url/

So i will change the two call on http to force https:

https://github.com/HubPress/dev.hubpress.io/blob/gh-pages/themes/uno/assets/scss/uno.scss#L2 https://github.com/HubPress/dev.hubpress.io/blob/gh-pages/themes/uno/assets/css/uno.css#L1

I will close this PR when it will be done.