Adding Influx v0.9 line protocol support

HubSpot / BuckyServer

Node server that receives metric data over HTTP & forwards to your service of choice

http://github.hubspot.com/bucky

MIT License

195 stars 33 forks source link

Adding Influx v0.9 line protocol support #17

Closed mr337 closed 8 years ago

mr337 commented 9 years ago

This PR adds line protocol support when using influxdb version 0.9 and use_json is true.

Backward compatibility is kept for JSON for 0.8 and 0.9. This PR doesn't support tagging for v0.9 via line protocol. I'd be interested to hear any ideas on how to support them since there are different tags for different sites/organizations.

JSMike commented 8 years ago

See https://github.com/HubSpot/BuckyServer/pull/18 It's more backwards compatible.

mr337 commented 8 years ago

Bleh, I'll take your word for it.

JSMike commented 8 years ago

I welcome criticism for my PR, sry if I came off harsh. 0.9 has deprecated json format, and it will be removed in 1.0, so I took it out as an option, 0.9 always sends as line protocol. I also included necessary changes for sending retention policy. Also, check out my changes to the client for influxDBLineProtocol https://github.com/JSMike/BuckyClient

mr337 commented 8 years ago

No not at all @JSMike, js and coffeescript are not my strong suit at all. In fact first time I have messed with coffeescript and influxdb. So been learning a lot recently!