search

HubSpot / BuckyServer

Node server that receives metric data over HTTP & forwards to your service of choice
http://github.hubspot.com/bucky
MIT License
194 stars 33 forks source link

Security changes whitelisting #22

Open msgauri opened 8 years ago

msgauri commented 8 years ago

Work in progress

msgauri commented 8 years ago

(this addresses #20)

msgauri commented 8 years ago

This one is ready to go in, waiting on review

ckdake commented 8 years ago

Could we check for the presence of whitelistedKeys and use that as the trigger to filter keys instead of having to use a separate boolean?

msgauri commented 8 years ago

So you need atleast one of those keys commented out for the server to start up, else it gives parse errors.

msgauri commented 8 years ago

@zackbloom could you review this and check if its ok to merge this?

msgauri commented 8 years ago

@zackbloom I have uncommented the default keys sent by bucky in the yaml. It should work in its current form. Please check and merge if everything looks right.

msgauri commented 8 years ago

@zackbloom wanted to check with you if you need anything from us after the last comment? Or is this ready to merge?