HubSpot / Singularity

Scheduler (HTTP API and webapp) for running Mesos tasks—long running processes, one-off tasks, and scheduled jobs. #hubspot-open-source
http://getsingularity.com/
Apache License 2.0
823 stars 188 forks source link

Block reconciliation if queue nearly full #2185

Closed rosalind210 closed 3 years ago

rosalind210 commented 3 years ago

If the queue is nearly full, adding a number of tasks for reconciliation can put us into a loop of lag as the scheduler tries to go through tasks and more reconciliation attempts.

ssalinas commented 3 years ago

let's test in staging, but looks good 👍 . We can do something like shrink the queue size really small + make an example request and scale it to something ridiculous like 300 to hopefully trigger and see it in action

rosalind210 commented 3 years ago

I tried adding unit tests, but the status queue was still processing them faster than I could run a reconciliation check so I wasn't able to hit the blocking conditional; and if I tried to create too many tasks, I was blocked by testing resources.

ssalinas commented 3 years ago

🚢

ssalinas commented 3 years ago

🚢