search

HubSpot / calling-extensions-sdk

A JavaScript SDK for integrating calling apps into HubSpot.
https://developers.hubspot.com/docs/api/crm/extensions/calling-sdk
MIT License
46 stars 29 forks source link

Update webpack config and npm scripts #114

Closed esme closed 1 year ago

esme commented 1 year ago

Description

Jira Ticket: CALL-3266

Serve index.html files from the public directory so that we don't need to build files using the npm start command.

Merge Checklist

Q A
Adds Documentation?
Any Dependency Changes?
Patch: Bug Fix?
Minor: New Feature?
Major: Breaking Change?

BRAVE Checklist

Q A
Backwards Compatible?
Rollout/Rollback Plan?
Automated test coverage?
Verified that changes work? ✅
Expect Dependencies to Fail?
github-actions[bot] commented 1 year ago

PR Preview Action v1.3.0 :---: :rocket: Deployed preview to https://HubSpot.github.io/calling-extensions-sdk/pr-preview/pr-114/ on branch gh-pages at 2023-04-27 22:53 UTC

esme commented 1 year ago

Awesome! Do we still need the serve commands now that start has been updated?

@alonso-cadenas I think it is still useful for running webpack-dev-server without any flags. We can always remove it if we're not using it in the future

alonso-cadenas commented 1 year ago

Awesome! Do we still need the serve commands now that start has been updated?

@alonso-cadenas I think it is still useful for running webpack-dev-server without any flags. We can always remove it if we're not using it in the future

Works for me!