Fix call logging and eslint errors - Githubissues

HubSpot / calling-extensions-sdk

A JavaScript SDK for integrating calling apps into HubSpot.

https://developers.hubspot.com/docs/api/crm/extensions/calling-sdk

MIT License

46 stars 29 forks source link

Fix call logging and eslint errors #126

Closed esme closed 1 year ago

esme commented 1 year ago

Description

Jira Ticket: CALL-3760

Fix logging of phone number "+1" in react demo app by updating dial number in handleStartCall and cti.outgoingCall().

Install eslint-plugin-react-hooks to enforce the rules of hooks and any missing dependencies
Install @typescript-eslint/eslint-plugin to run ESLint with recommended TS rules

Merge Checklist

Q	A
Adds Documentation?
Any Dependency Changes?
Patch: Bug Fix?	✅
Minor: New Feature?
Major: Breaking Change?

BRAVE Checklist

[x] I have read the BRAVE checklist and confirmed if the following is necessary.

Q	A
Backwards Compatible?
Rollout/Rollback Plan?	Patch
Automated test coverage?
Verified that changes work?	✅
Expect Dependencies to Fail?

github-actions[bot] commented 1 year ago

PR Preview Action v1.4.4 :---: :rocket: Deployed preview to https://HubSpot.github.io/calling-extensions-sdk/pr-preview/pr-126/ on branch gh-pages at 2023-05-24 03:56 UTC

alonso-cadenas commented 1 year ago

Running npm run publish:alpha