search

HubSpot / calling-extensions-sdk

A JavaScript SDK for integrating calling apps into HubSpot.
https://developers.hubspot.com/docs/api/crm/extensions/calling-sdk
MIT License
45 stars 29 forks source link

Use production mode to build the SDK bundle. #175

Closed alonso-cadenas closed 6 months ago

alonso-cadenas commented 6 months ago

Description

Jira Ticket: CALLING-11266

We are using the development mode to build the main.js bundle of the npm package. This causes issues when installing the package via a CDN, and lacks optimization.

Merge Checklist

Q A
Adds Documentation?
Any Dependency Changes?
Patch: Bug Fix? :white_check_mark:
Minor: New Feature?
Major: Breaking Change?

BRAVE Checklist

Q A
Backwards Compatible? :white_check_mark:
Rollout/Rollback Plan?
Automated test coverage?
Verified that changes work? :white_check_mark:
Expect Dependencies to Fail? :white_check_mark:
alonso-cadenas commented 6 months ago

I can't create alpha/beta patch versions because they collide with the alpha previously created in proj-inbound-calling. Given the small change and successful testing, we should proceed with the direct publish to the new patch version.