Add toggle to enforce order of events in the demo minimal js

HubSpot / calling-extensions-sdk

A JavaScript SDK for integrating calling apps into HubSpot.

https://developers.hubspot.com/docs/api/crm/extensions/calling-sdk

MIT License

46 stars 29 forks source link

Add toggle to enforce order of events in the demo minimal js #203

Closed esme closed 2 months ago

esme commented 5 months ago

Description

Jira Ticket: CALL-6601

Use state.enforceButtonsOrder to enforce order of events in the demo minimal js. It is set to false by default. This enables us to test asynchronous SDK events for inbound calling.

Merge Checklist

Q	A
Adds Documentation?
Any Dependency Changes?
Patch: Bug Fix?	yes
Minor: New Feature?
Major: Breaking Change?

BRAVE Checklist

[ ] I have read the BRAVE checklist and confirmed if the following is necessary.

Q	A
Backwards Compatible?
Rollout/Rollback Plan?
Automated test coverage?
Verified that changes work?
Expect Dependencies to Fail?

github-actions[bot] commented 5 months ago

PR Preview Action v1.4.7 :---: :rocket: Deployed preview to https://HubSpot.github.io/calling-extensions-sdk/pr-preview/pr-203/ on branch gh-pages at 2024-08-05 22:27 UTC

hemang-thakkar commented 5 months ago

Would it be helpful if we add a button to toggle enforceButtonsOrder instead of doing thru console? just for easy testing

alonso-cadenas commented 3 months ago

@esme checking in on the status of this PR.

esme commented 3 months ago

As this supports a specific use case that isn't directly related to the CTI experience, could we follow up with a developer interface if needed?

esme commented 2 months ago

@hemang-thakkar Let me know if this PR is good to go!