search

HubSpot / cms-theme-boilerplate

A straight-forward starting point for building a great website on the HubSpot CMS
https://boilerplate.hubspotcms.com
Other
355 stars 355 forks source link

Breadcrumbs module #362

Open johnsfuller opened 3 years ago

johnsfuller commented 3 years ago

Breadcrumbs are widely used. I think a breadcrumbs module or macro would be great for blogs and even drag and drop pages. Depending on v3's timeline and my work load, I'd be happy to contribute

Checklist

jasonnrosa commented 3 years ago

Hey @johnsfuller! Out of curiosity, would this be something that you'd expect as a separate module or would you anticipate this would be something that would be part of a menu module? In terms of timeline for v3, we are looking at some time in the next couple of weeks but this would be a non breaking change to add a new module so we could really add something like this in any future minor/major release.

johnsfuller commented 3 years ago

Dang, that's a good question. I imagine breadcrumbs wouldn't come to mind for the typical drag and drop user. So I lean towards a separate module. But I've been wrong before...

jasonnrosa commented 3 years ago

I like the idea of a separate module 👍🏼 feel free to toss up a PR if this is something you're interested in tackling. v3 should hopefully be wrapped up early next week but given this is not a breaking change, there is no rush on getting it in for that particular project board (we can always toss it in a future version).