HubSpot / cms-theme-boilerplate

A straight-forward starting point for building a great website on the HubSpot CMS
https://boilerplate.hubspotcms.com
Other
355 stars 355 forks source link

Update theme label in theme.json to use sentence casing #411

Closed jasonnrosa closed 2 years ago

jasonnrosa commented 2 years ago

Update the theme label in the theme.json file to use sentence casing to match style guide/Canvas. Sentence casing would mean "Boilerplate theme" as opposed to title casing which would be "Boilerplate Theme"

ckconant commented 2 years ago

@jasonnrosa is the theme.json label considered a title? I've aways found obscurity in the canvas typography guidelines around casing:

It is a small nit, and I personally love sentence casing, but curious of when to use title casing...

jasonnrosa commented 2 years ago

@ckconant we still need to chat about this one a bit more internally but the more detailed canvas writing details have:

In this specific case, the theme label is most often used as a subheader in app vs. an h1/main header which is why we might be leaning towards changing it to sentence casing.

ckconant commented 2 years ago

Totally makes sense. Like I said, just a nit.

Also, Headings* 😉

jasonnrosa commented 2 years ago

Closed per (https://github.com/HubSpot/cms-theme-boilerplate/pull/430)