HubSpot / cms-theme-boilerplate

A straight-forward starting point for building a great website on the HubSpot CMS
https://boilerplate.hubspotcms.com
Other
355 stars 355 forks source link

Adding hs-button class to theme button styles #475

Closed jasonnrosa closed 1 year ago

jasonnrosa commented 1 year ago

Types of change

Description

Per the issue linked below, theme styles applied to theme settings wouldn't apply to the default button module which can be confusing for a user. We have some plans to make this better long term in other ways (e.g. in this case I think improving the default button and not having a theme specific version would help/being able to hide the default in favor of a theme module; and being able to reliably inherit from theme settings from default modules will also help) but in the interim this should help ensure that theme settings apply to the default and theme module in this case.

Relevant links

Example page: Example page with default and theme module stacked on top of each other GitHub issue: fixes #463

Checklist